Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve story descriptions for Color Sample #413

Merged
merged 6 commits into from
Dec 20, 2024
Merged

Conversation

Robbert
Copy link
Member

@Robbert Robbert commented Dec 20, 2024

  • Door toevoegen linkjes naar Wikipedia is het makkelijker om te beoordelen of de kleurnamen in een andere taal kloppen.
  • Duidelijk maken dat de checkerboard pattern en hex-kleurcodes voor een professionele doelgroep is, die het gewend zijn en begrijpen wat het betekent.
  • updaten van Voorbeeld thema voor beter contrast van de border, nadat deze PR is gemerged en de release PR is gemerged
  • Story toevoegen voor lichte kleur

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
candidate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 2:56pm
candidate-storybook-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 2:56pm
evil-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 2:56pm

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f69bfb1) to head (6f9fc12).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #413   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          370       370           
  Branches        32        28    -4     
=========================================
  Hits           370       370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matijs matijs merged commit fca27e8 into main Dec 20, 2024
10 of 11 checks passed
@matijs matijs deleted the docs/color-sample2 branch December 20, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants