Bump version #12
Annotations
5 errors and 8 warnings
this expression creates a reference which is immediately dereferenced by the compiler:
src/lib.rs#L49
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/cli/profile.rs:49:9
|
49 | &app_state,
| ^^^^^^^^^^ help: change this to: `app_state`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/lib.rs#L68
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/cli/profile.rs:68:82
|
68 | let profile = select_profile("Select which profile you would like to view:", &app_state)?;
| ^^^^^^^^^^ help: change this to: `app_state`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
assigning the result of `ToOwned::to_owned()` may be inefficient:
src/lib.rs#L52
error: assigning the result of `ToOwned::to_owned()` may be inefficient
--> src/profiles/profile.rs:52:9
|
52 | self.playlist_id = playlist_id.to_owned()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `playlist_id.clone_into(&mut self.playlist_id)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `-D clippy::assigning-clones` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::assigning_clones)]`
|
question mark operator is useless here:
src/lib.rs#L70
error: question mark operator is useless here
--> src/profiles/wizards.rs:70:5
|
70 | / Ok(ProfileTitle::new(profile_name)
71 | | .with_context(|| "Error setting profile title from wizard")?)
| |_____________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
= note: `-D clippy::needless-question-mark` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_question_mark)]`
help: try removing question mark and `Ok()`
|
70 ~ ProfileTitle::new(profile_name)
71 + .with_context(|| "Error setting profile title from wizard")
|
|
aborting due to 4 previous errors
error: aborting due to 4 previous errors
|
format
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
format
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, auguwu/clippy-action@1.2.1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
check
clippy-action doesn't have permissions to view Check Runs, disabling!
|
check
Resource not accessible by integration
|