Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the state and RHS from the models #115

Open
Sbte opened this issue Jul 6, 2020 · 1 comment
Open

Remove the state and RHS from the models #115

Sbte opened this issue Jul 6, 2020 · 1 comment
Assignees
Milestone

Comments

@Sbte
Copy link
Member

Sbte commented Jul 6, 2020

The models don't have an actual state. They just have some functions that take a state as input (at least mathematically). Removing the state and RHS from the models would make this more clear.

It may still be useful to have an initial state that can be obtained from the model, just so we know the initial state is valid, and so we can more easily load a state from a file.

@Sbte Sbte added this to the Code paper milestone Jul 6, 2020
@Sbte Sbte self-assigned this Jul 7, 2020
@Sbte
Copy link
Member Author

Sbte commented Jan 18, 2021

Problem with this is that the models other than Ocean also have this and use it more prominently, and that it is used for saving/loading states from files (also legacy Fortran files). I'm not sure if it's worth it to restructure this, even though it is probably safer and more correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant