Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that calling setParameters also correctly changes the internal state #73

Open
Sbte opened this issue Jan 23, 2020 · 2 comments
Milestone

Comments

@Sbte
Copy link
Member

Sbte commented Jan 23, 2020

For instance in THCM and SeaIce, there are many variables that depend on parameters that are only set correctly in the constructor, not in setParameters. If parameters are supposed to be handled correctly, implement this in setParameters, not the constructor. If these should be immutable, remove the parameter setting from setParameters.

@Sbte Sbte added this to the Code paper milestone Jul 6, 2020
@merijn
Copy link
Collaborator

merijn commented Jul 30, 2020

@Sbte I'm cleaning up issues and wondering if this is still an issue? Currently THCM only has the few "correct" parameters in setParameters and everything else has nothing, so as long as we don't add anything to setParameters without checking if this still holds this issue should be solved?

@Sbte
Copy link
Member Author

Sbte commented Jul 30, 2020

Well, I assume porting all other classes to this method of setting parameters is still in the pipeline? Because in that case this still has to be done correctly for all parameters that can be used in a continuation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants