You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For instance in THCM and SeaIce, there are many variables that depend on parameters that are only set correctly in the constructor, not in setParameters. If parameters are supposed to be handled correctly, implement this in setParameters, not the constructor. If these should be immutable, remove the parameter setting from setParameters.
The text was updated successfully, but these errors were encountered:
@Sbte I'm cleaning up issues and wondering if this is still an issue? Currently THCM only has the few "correct" parameters in setParameters and everything else has nothing, so as long as we don't add anything to setParameters without checking if this still holds this issue should be solved?
Well, I assume porting all other classes to this method of setting parameters is still in the pipeline? Because in that case this still has to be done correctly for all parameters that can be used in a continuation.
For instance in THCM and SeaIce, there are many variables that depend on parameters that are only set correctly in the constructor, not in setParameters. If parameters are supposed to be handled correctly, implement this in setParameters, not the constructor. If these should be immutable, remove the parameter setting from setParameters.
The text was updated successfully, but these errors were encountered: