Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed local ip lookup on macOS GitHub instances. #57

Closed
wants to merge 2 commits into from

Conversation

nmoinvaz
Copy link
Owner

@nmoinvaz nmoinvaz commented Dec 12, 2023

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (8d75d9c) 55.68% compared to head (d53c2e7) 47.57%.

Files Patch % Lines
net_util.c 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   55.68%   47.57%   -8.12%     
==========================================
  Files          53       53              
  Lines        4606     4599       -7     
  Branches     1062     1059       -3     
==========================================
- Hits         2565     2188     -377     
- Misses       1368     1784     +416     
+ Partials      673      627      -46     
Flag Coverage Δ
macos 45.47% <66.66%> (+0.01%) ⬆️
ubuntu 40.97% <66.66%> (-12.45%) ⬇️
ubuntu_curl 41.33% <66.66%> (-11.75%) ⬇️
windows 52.98% <66.66%> (-3.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nmoinvaz nmoinvaz force-pushed the nathan/test/mac-os-dns branch 2 times, most recently from 0653b47 to 5faa75a Compare December 12, 2023 02:43
@nmoinvaz nmoinvaz added the bug Something isn't working label Dec 12, 2023
@nmoinvaz nmoinvaz marked this pull request as ready for review December 12, 2023 02:44
@nmoinvaz nmoinvaz changed the title Try fixing local dns lookup on macOS instances. Fixed local address lookup on macOS instances. Dec 12, 2023
@nmoinvaz nmoinvaz changed the title Fixed local address lookup on macOS instances. Fixed local ip lookup on macOS GitHub instances. Dec 12, 2023
@nmoinvaz nmoinvaz marked this pull request as draft December 12, 2023 02:48
@nmoinvaz nmoinvaz closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant