Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win: build with WIN32_LEAN_AND_MEAN macro defined globally #62

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

sergio-nsk
Copy link
Collaborator

No description provided.

@sergio-nsk sergio-nsk added the bug Something isn't working label Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.10%. Comparing base (6bc5050) to head (652aa06).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   57.19%   57.10%   -0.10%     
==========================================
  Files          53       53              
  Lines        4670     4709      +39     
  Branches     1077     1078       +1     
==========================================
+ Hits         2671     2689      +18     
- Misses       1307     1322      +15     
- Partials      692      698       +6     
Flag Coverage Δ
macos 51.81% <ø> (+<0.01%) ⬆️
ubuntu 53.74% <ø> (+0.03%) ⬆️
ubuntu_curl 53.07% <ø> (-0.33%) ⬇️
windows 56.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergio-nsk sergio-nsk changed the title win: fix build when WIN32_LEAN_AND_MEAN is defined globally win: build with WIN32_LEAN_AND_MEAN macro defined globally Aug 14, 2024
@sergio-nsk sergio-nsk added enhancement New feature or request and removed bug Something isn't working labels Aug 14, 2024
@nmoinvaz
Copy link
Owner

Can you try to add a commit that removes -user from gcovr command?

`python3 -u -m pip install gcovr` raised
error: externally-managed-environment
@nmoinvaz
Copy link
Owner

It shouldn't be using brew. It should still use python. All I was suggesting was removing -user.

@nmoinvaz
Copy link
Owner

brew not available on Windows and Linux so..

@sergio-nsk
Copy link
Collaborator Author

sergio-nsk commented Aug 14, 2024

This is macos.yaml. Removing --user did not resolve the error.
https://github.com/nmoinvaz/proxyres/actions/runs/10394851768/job/28785595883#step:23:50

@nmoinvaz
Copy link
Owner

Hmm

@sergio-nsk sergio-nsk enabled auto-merge (rebase) August 14, 2024 21:28
@sergio-nsk sergio-nsk merged commit 2fbf787 into master Aug 14, 2024
17 of 18 checks passed
@sergio-nsk sergio-nsk deleted the sergio-nsk/mean_and_lean/1 branch August 14, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants