Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/allow duplicates #104

Open
wants to merge 5 commits into
base: release/7.12.0
Choose a base branch
from
Open

Feature/allow duplicates #104

wants to merge 5 commits into from

Conversation

Jarek-Rolski
Copy link
Contributor

New attribute allow_duplicates defines if column allows duplicated values.

  • API, SDK and UI are updated.
  • Validation method for schema upload throws error if any column forbids duplicates and overwrite behaviour is APPEND.
  • Validation method for dataset upload ignores null values in column.
  • Error message for dataset upload returns columns names with duplicated values.
  • Default attribute value is "True"
  • Test for schema and dataset upload with allow_duplicates is passed.

I updated UI "jest" tests with new attribute. I didn't add any new more detailed test checking how attribute works in UI because "jest" and "playwright" UI tests in repository do not check such details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jarek-Rolski