Smooth merge #155
Merged
Smooth merge #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SorooshMani-NOAA, it seems like 2 tests failed for reasons unrelated to the changes I just made. How do you want me to proceed? |
|
Let's address the failing test in a separate pull request at some point. It seems to have something to do with latest jigsawpy and python 3.9. I'm just guessing ... everything else looks good. Thank you! |
SorooshMani-NOAA
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge_overlapping_meshes function added. tests also added.
This will allow merging meshes with smooth transitions, e.g. (floodplain, river, ocean meshes)