Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remesh_tiny_elements keyword to driver.run() #176

Conversation

SanderHulst
Copy link
Contributor

Hey guys,

We are creating a batch of meshes for storm surge modelling. I cannot get the global grid to predict tides correctly.

Sometimes our bathymetry shows some large gradient and jigsaw responds with an area of tiny elements. I noticed in the code that this is not new and a keyword should be added if this pops again. As the last JigSaw version is of 2020 (right?) I think we should add the keyword.

With best regards,
Sander (and Matthijs)

@felicio93
Copy link
Collaborator

We have utility scripts for fixing these small area elements.
I have no objections to the change proposed. @SorooshMani-NOAA, are you ok with the PR?

@SorooshMani-NOAA
Copy link
Collaborator

Looks fine to me too, feel free to merge!

@felicio93
Copy link
Collaborator

Ok, passed all tests. Merging..

@felicio93 felicio93 merged commit bcccf8e into noaa-ocs-modeling:main Sep 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants