added functions for cleaning RiverMapper invalid geoms #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SorooshMani-NOAA, this PR took a few attempts because as you might remember the GitHub Actions workflows using v3 were deprecated earlier this month. So, I had to update all the workflows to use v4. The Pylint check also seem to have been updated. Our Pylint score went down (failed), apparently because now ourtoo-many-positional-arguments functions are being flagged. It will require a lot of work to refactor all the OCSMesh functions flagged. For now I just updated the pylint run to be: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem and solution are explained here
The following functions are added:
validate_poly
find_polyneighbors
validate_RMmesh
triangulate_rivermapper_poly
the previous triangulate_rivermapper_poly function was renamed to triangulate_poly