Remove checkDeveloperProductName reference from addDeveloperPoduct (redundant and deprecated) #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oduct (redundant and deprecated)
alanbixby
added
help wanted
Neztore
approved these changes
Aug 1, 2024
Neztore
added
major
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending a duplicate name now returns an HTTP 400 with the response
{"errorCode":"DuplicateProductName","errorMessage":"The request parameter name was invalid. Developer product name already exists in the universe.","field":"name","hint":null}As such, Roblox deprecated
checkDeveloperProductNameand it is now 404'ing, thus breakingaddDeveloperProduct- hence its removal.The
apis.endpoint also has a different return type which was not documented in the previous PR, this is not a breaking change as the migration is already in the library.This change still needs better error handling + testing to be done. The PR is entered as a draft for other's reference.