Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support passing iree flags for LLMs #1754

Merged
merged 1 commit into from
Aug 14, 2023
Merged

add support passing iree flags for LLMs #1754

merged 1 commit into from
Aug 14, 2023

Conversation

PhaneeshB
Copy link
Contributor

@PhaneeshB PhaneeshB commented Aug 13, 2023 •
edited
Loading

  • required for passing target triple from command line when running LLMs on web and cli
  • NOTE:
    • target triple for Sharded LLMs is experimental as of now.
    • duplicate args from SD and LLMs will need to be refactored into a more disjoint set of cli args to prevent the argparse objects from eating up each others values when used in the same file.

@PhaneeshB PhaneeshB enabled auto-merge (rebase) August 13, 2023 17:43
@jinchen62
Copy link
Contributor

Does it work for cli?

@PhaneeshB
Copy link
Contributor Author

PhaneeshB commented Aug 14, 2023 •
edited
Loading

Does it work for cli?

Yes @jinchen62, added support for cli too.
Thanks

jinchen62
jinchen62 approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@jinchen62 jinchen62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhaneeshB PhaneeshB merged commit 4f61d69 into nod-ai:main Aug 14, 2023
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinchen62 jinchen62 jinchen62 approved these changes

@dan-garvey dan-garvey Awaiting requested review from dan-garvey

@Eliasj42 Eliasj42 Awaiting requested review from Eliasj42

@powderluv powderluv Awaiting requested review from powderluv

@Shukla-Gaurav Shukla-Gaurav Awaiting requested review from Shukla-Gaurav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhaneeshB @jinchen62