Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Studio) Update gradio and multicontrolnet UI. #2001

Merged
merged 12 commits into from
Dec 4, 2023
Merged

Conversation

monorimet
Copy link
Collaborator

Updates gradio pin to 4.7, which might just break everything apparently.

What else does this break? I'd like the new gradio features.

@monorimet monorimet force-pushed the ean-mcn-gradio branch 3 times, most recently from e529627 to 36d7bf0 Compare December 2, 2023 11:10
@monorimet
Copy link
Collaborator Author

FYI @one-lithe-rune you might have opinions about this change

@monorimet
Copy link
Collaborator Author

TODO: fix nod logo, see about controlnet issues.

@one-lithe-rune
Copy link
Contributor

FYI @one-lithe-rune you might have opinions about this change

I wasn't following along with what the issue was that caused gradio to be pinned this time around, but its generally best to bite the bullet to upgrade, and then fix up, unless there is a known gradio bug that is blocking us, or we're looking do a stable release real soon.

It would be useful to get things like the new file picker for instance, and the longer we leave it the worse it always gets.

However, I'm currently working on some LoRA fixes/changes with pieces all over the floor in an 'I don't want to even commit locally' state atm, plus I expect to need to start doing a job search sometime next week, so I'm a bit tied up to look at stuff atm.

@monorimet monorimet force-pushed the ean-mcn-gradio branch 3 times, most recently from 8f1014a to af6f5d8 Compare December 4, 2023 13:26
@@ -19,6 +19,9 @@ a = Analysis(
win_private_assemblies=False,
cipher=block_cipher,
noarchive=False,
module_collection_mode={
'gradio': 'py', # Collect gradio package as source .py files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont even want to know how you figured out this was required...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wasnt collecting some random source files
tried adding metadata and hidden files, nope, ok just gimme it all then

@monorimet monorimet merged commit d72da38 into main Dec 4, 2023
6 of 9 checks passed
monorimet added a commit that referenced this pull request Dec 12, 2023
* (Studio) Update gradio and multicontrolnet UI.

* Fixes for outputgallery, exe build

* Fix image return types.

* Update Gradio to 4.7.1

* Fix send buttons and hiresfix

* Various bugfixes and SDXL additions.

* More UI fixes and txt2img_sdxl presets.

*enable SDXL-Turbo and custom models, custom VAE for sdxl

* img2img ui tweaks
@monorimet monorimet deleted the ean-mcn-gradio branch January 5, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants