Unit tests for Grovers, Measure nodes

quantum/errors.js

@@ -127,6 +127,7 @@ module.exports = {
   QUBITS_FROM_DIFFERENT_CIRCUITS,
   SAME_QUBIT_RECEIVED_TWICE,
   BLOCH_SPHERE_WITH_MEASUREMENT,
+  NOT_BIT_STRING,
   validateQubitInput,
   validateRegisterInput,
   validateQubitsFromSameCircuit,

quantum/nodes/grovers/grovers.js

@@ -14,7 +14,8 @@ module.exports = function(RED) {
     this.on('input', async function(msg, send, done) {
       let error = errors.validateGroversInput(msg);
       if (error) {
-        done(error);
+        this.error(error.message);
+        done();
         return;
       }
 

quantum/nodes/quantum-circuit/quantum-circuit.js

@@ -21,6 +21,7 @@ module.exports = function(RED) {
     this.qbitsreg = parseInt(config.qbitsreg);
     this.cbitsreg = parseInt(config.cbitsreg);
     this.outputs = parseInt(config.outputs);
+    this.shell = shell;
     const state = stateManager.newState(this.id);
     const node = this;
 

test/flow-builder.js

@@ -23,6 +23,7 @@ const NODES = {
   'swap': require('../quantum/nodes/swap/swap.js'),
   'toffoli-gate': require('../quantum/nodes/toffoli-gate/toffoli-gate.js'),
   'unitary-gate': require('../quantum/nodes/unitary-gate/unitary-gate.js'),
+  'grovers': require('../quantum/nodes/grovers/grovers')
 };
 
 class FlowBuilder {

test/nodes/grovers_spec.js

@@ -2,6 +2,8 @@ const groversNode = require('../../quantum/nodes/grovers/grovers.js');
 const testUtil = require('../test-util');
 const nodeTestHelper = testUtil.nodeTestHelper;
 const assert = require('chai').assert;
+const {FlowBuilder} = require('../flow-builder');
+const errors = require('../../quantum/errors');
 
 
 describe('GroversNode', function() {
@@ -19,34 +21,38 @@ describe('GroversNode', function() {
   });
 
   it('default name outputs correctly', function(done) {
-    let flow = [{id: 'groversNode', type: 'grovers', wires: []}];
-    nodeTestHelper.load(groversNode, flow, function() {
+    flow = new FlowBuilder();
+    flow.add('grovers', 'groversNode', []);
+
+    nodeTestHelper.load(flow.nodes, flow.flow, function() {
       let groversTestNode = nodeTestHelper.getNode('groversNode');
-      groversTestNode.should.have.property('name', 'Grovers');
+      groversTestNode.should.have.property('name', 'grovers');
       done();
     });
   });
 
   it('return success output on valid input', function(done) {
-    let flow = [{id: 'groversNode', type: 'grovers', wires: [['helperNode']]},
-      {id: 'helperNode', type: 'helper'}];
+    flow = new FlowBuilder();
+    flow.add('grovers', 'n1', [['n2']]);
+    flow.addOutput('n2');
+
+    const givenInput = {payload: '111111'};
+    const expectedOutput = { topMeasurement: '111111', iterationsNum: 6};
+
+    testUtil.correctOutputReceived(flow, givenInput, expectedOutput, done);
+  });
+
+  it('should fail on invalid input', function(done) {
+    flow  = new FlowBuilder();
+    flow.add('grovers', 'groversNode', []);
 
-    nodeTestHelper.load(groversNode, flow, function() {
+    nodeTestHelper.load(flow.nodes, flow.flow, function() {
       let groversTestNode = nodeTestHelper.getNode('groversNode');
-      let helperNode = nodeTestHelper.getNode('helperNode');
-
-      helperNode.on('input', function(msg) {
-        const expectedPayload = { topMeasurement: '111111', iterationsNum: 6};
-        try {
-          assert.strictEqual(msg.payload.topMeasurement, expectedPayload.topMeasurement);
-          assert.strictEqual(msg.payload.iterationsNum, expectedPayload.iterationsNum);
-          done();
-        } catch (err) {
-          done(err);
-        }
+      groversTestNode.on('call:error', call => {
+        call.should.be.calledWithExactly(errors.NOT_BIT_STRING);
+        done();
       });
-
-      groversTestNode.receive({payload: '111111'});
+      groversTestNode.receive({payload: '111112'});
     });
   });
 });

test/nodes/measure_spec.js

@@ -1,6 +1,7 @@
 const measureNode = require('../../quantum/nodes/measure/measure.js');
 const testUtil = require('../test-util');
 const nodeTestHelper = testUtil.nodeTestHelper;
+const {FlowBuilder} = require('../flow-builder');
 
 
 describe('MeasureNode', function() {
@@ -16,4 +17,20 @@ describe('MeasureNode', function() {
   it('load node', function(done) {
     testUtil.isLoaded(measureNode, 'measure', done);
   });
+
+  it('should return correct output', function(done) {
+    let flow = new FlowBuilder();
+
+    flow.add('quantum-circuit', 'n0', [['n1']],
+      {structure: 'qubits', outputs: '1', qbitsreg: '1', cbitsreg: '1'});
+    flow.add('not-gate', 'n1', [['n2']]);
+    flow.add('measure', 'n2', [['n3']], {selectedBit: '0'});
+    flow.add('local-simulator', 'n3', [['n4']], {shots: 1});
+    flow.addOutput('n4');
+
+    const givenInput = 'dummy input';
+    const expectedOutput = {1: 1};
+
+    testUtil.correctOutputReceived(flow, givenInput, expectedOutput, done);
+  });
 });

test/test-util.js

@@ -18,7 +18,32 @@ function isLoaded(node, nodeName, done) {
   });
 }
 
+function correctOutputReceived(flow, givenInput, expectedOutput, done) {
+  nodeTestHelper.load(flow.nodes, flow.flow, function() {
+    const inputNodeId = flow.flow[0].id;
+    const inputNode = nodeTestHelper.getNode(inputNodeId);
+
+    const outputNodeId = flow.flow[flow.flow.length - 1].id;
+    const outputNode = nodeTestHelper.getNode(outputNodeId);
+
+    outputNode.on('input', function(msg){
+      try {
+        assert.deepEqual(msg.payload, expectedOutput);
+        done();
+      }
+      catch(err){
+        done(err);
+      }
+      finally{
+        inputNode.shell.stop();
+      }
+    });
+    inputNode.receive(givenInput);
+  });
+}
+
 module.exports = {
   nodeTestHelper,
+  correctOutputReceived,
   isLoaded,
 };