Apply suggestions from code review

nodejs · Jun 28, 2023 · 7b7253f · 7b7253f
1 parent 23b8114
commit 7b7253f
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 6 deletions.
diff --git a/.github/workflows/closeVote.yml b/.github/workflows/closeVote.yml
@@ -65,7 +65,7 @@ jobs:
           git fetch origin '${{ steps.branch.outputs.head }}'
           git reset FETCH_HEAD --mixed
           git checkout HEAD -- '${{ steps.branch.outputs.head }}'
-      - run: npm install @aduh95/caritat
+      - run: npm install @node-core/caritat
       - name: Attempt closing the vote
         id: vote-summary
         run: |

diff --git a/.github/workflows/initiateNewVote.yml b/.github/workflows/initiateNewVote.yml
@@ -74,7 +74,7 @@ jobs:
       - name: Reset to the base branch
         run: git fetch origin HEAD && git reset FETCH_HEAD --hard
       - name: Install npm dependencies
-        run: npm install @aduh95/caritat
+        run: npm install @node-core/caritat
       - name: Configure git
         run: |
           git config --global user.email "github-bot@iojs.org"

diff --git a/.github/workflows/watchVote.yml b/.github/workflows/watchVote.yml
@@ -29,7 +29,7 @@ jobs:
         run:
           curl -L https://raw.githubusercontent.com/nodejs/node/main/.mailmap >>
           .mailmap
-      - run: npm install @aduh95/caritat
+      - run: npm install @node-core/caritat
       - name: Get PR description
         id: desc
         run: |

diff --git a/votes/initiateNewVote/decryptPrivateKeyAndCloseVote.mjs b/votes/initiateNewVote/decryptPrivateKeyAndCloseVote.mjs
@@ -6,7 +6,7 @@ import { createInterface as readLines } from "node:readline";
 import { fileURLToPath } from "node:url";
 import { parseArgs } from "node:util";
 
-import countFromGit from "@aduh95/caritat/countBallotsFromGit";
+import countFromGit from "@node-core/caritat/countBallotsFromGit";
 
 const { values: parsedArgs } = parseArgs({
   options: {

diff --git a/votes/initiateNewVote/generateNewVotePR.mjs b/votes/initiateNewVote/generateNewVotePR.mjs
@@ -9,7 +9,7 @@ import { open, readFile } from "node:fs/promises";
 import { parseArgs } from "node:util";
 import { spawn } from "node:child_process";
 
-import generateNewVoteFolder from "@aduh95/caritat/generateNewVoteFolder";
+import generateNewVoteFolder from "@node-core/caritat/generateNewVoteFolder";
 
 import readReadme from "./extractInfoFromReadme.mjs";
 
@@ -256,6 +256,8 @@ Vote instructions:
 To close the vote, at least ${shareholderThreshold} secret holder(s)[^1] must \
 run the following command: ${"`"}git node vote ${prUrl} --decrypt-key-part --post-comment${"`"}
 
+/cc @nodejs/tsc
+
 [^1]: secret holders are folks who have access to the private key associated with \
 a public key on <${keyServerURL}> that references an email address listed on the \
 TSC voting member list at the time of the opening of the vote.

diff --git a/votes/initiateNewVote/getVoteStatus.mjs b/votes/initiateNewVote/getVoteStatus.mjs
@@ -2,7 +2,7 @@
 
 import { exit } from "node:process";
 import { env } from "node:process";
-import count from "@aduh95/caritat/countParticipationFromGit";
+import count from "@node-core/caritat/countParticipationFromGit";
 
 const START_MARKER = "<!-- BEGIN PARTICIPATION -->";
 const END_MARKER = "<!-- END PARTICIPATION -->";