From de78d34037b380b32c280d0da8c1ed2c116fdc4d Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Mon, 17 Jun 2024 17:43:17 +0200 Subject: [PATCH] Propose vote to unblock `--env-file` PRs (#1577) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Propose vote to unblock `--env-file` PRs Refs: https://github.com/nodejs/TSC/issues/1575#issuecomment-2166976221 * Apply suggestions from code review Co-authored-by: Tobias Nießen * Apply suggestions from code review * Apply suggestions from code review --------- Co-authored-by: Tobias Nießen --- votes/initiateNewVote/_EDIT_ME.yml | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/votes/initiateNewVote/_EDIT_ME.yml b/votes/initiateNewVote/_EDIT_ME.yml index c9fac556..4849d1ab 100644 --- a/votes/initiateNewVote/_EDIT_ME.yml +++ b/votes/initiateNewVote/_EDIT_ME.yml @@ -3,7 +3,7 @@ # 1. Select a subject for the vote. This can be a question addressed to the TSC # voting members. -subject: REPLACEME +subject: How should `node` handle non-existent `.env` files passed via CLI flags? # 2. You can leave the header instructions as is, or modify them if you see fit. headerInstructions: | @@ -24,8 +24,14 @@ headerInstructions: | # voters express their preference for each candidates, no matter how many # there are. candidates: - - TODO - - TODO + - Throw when passed to `--env-file` flag, provide no other flag (status quo). + - Ignore when passed to `--env-file` flag, provide no other flag. + - Warn when passed to `--env-file` flag, provide no other flag. + - Throw when passed to `--env-file` flag, warn when passed to a new `--env-file-if-exists`. + - Throw when passed to `--env-file` flag, ignore when passed to a new `--env-file-if-exists`. + - Ignore when passed to `--env-file` flag, throw when passed to a new `--env-file-must-exist`. + - Throw when passed to `--env-file` flag, unless new `--env-file-when-missing=warn` is also passed. + - Warn when passed to `--env-file` flag, unless new `--env-file-when-missing=throw` is also passed. # 4. Pass the following to false if it's important to keep the candidates in the # order you define above. Presenting candidates in a fixed order tends to @@ -35,11 +41,16 @@ canShuffleCandidates: true # 5. Insert here a short description of the vote objectives and link to the # issue it was discussed on to give the full context. footerInstructions: | - TBD + Based on the result of this vote, we can unblock either https://github.com/nodejs/node/pull/53177, + https://github.com/nodejs/node/pull/53060, or neither if the status quo prevails. The name of the + proposed flags are non-binding, and are provided only as examples. If a proposal that includes a + new flag is accepted, the name of that flag can be bike-shed per the PR review process. + "Ignore" means "do not throw and do not warn" in this context. # 6. Optionally, insert a brief introduction for the vote PR, in the markdown format. prBody: | + The vote should stay open for 7 days, or until all TSC voting members have cast a ballot. # 7. Optionally, choose an id that will be used for the branch name as well as # the vote folder name. If not supplied, a UUID will be used. -path-friendly-id: null +path-friendly-id: how-to-handle-missing-env-files