-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request for vote to reduce inactive collaborator duration #1536
Changes from all commits
5c9e18c
373771e
c200395
04da6fc
ffd8d70
e3f7311
1f9abeb
09e4899
4174dfa
ae5b44c
4cb09d5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -3,7 +3,7 @@ | |||
|
||||
# 1. Select a subject for the vote. This can be a question addressed to the TSC | ||||
# voting members. | ||||
subject: REPLACEME | ||||
subject: Reduce inactive collaborator duration | ||||
|
||||
# 2. You can leave the header instructions as is, or modify them if you see fit. | ||||
headerInstructions: | | ||||
|
@@ -24,8 +24,8 @@ headerInstructions: | | |||
# voters express their preference for each candidates, no matter how many | ||||
# there are. | ||||
candidates: | ||||
- TODO | ||||
- TODO | ||||
- Status quo: Keep the current inactive collaborator duration of 12 months | ||||
- Reduce the inactive collaborator duration to 9 months | ||||
|
||||
# 4. Pass the following to false if it's important to keep the candidates in the | ||||
# order you define above. Presenting candidates in a fixed order tends to | ||||
|
@@ -35,10 +35,20 @@ canShuffleCandidates: true | |||
# 5. Insert here a short description of the vote objectives and link to the | ||||
# issue it was discussed on to give the full context. | ||||
footerInstructions: | | ||||
TBD | ||||
The objective of this vote is to decide whether the duration to determine | ||||
inactivity should be reduced from 12 months to 9 months. This vote was discussed | ||||
in pull request https://github.com/nodejs/node/pull/52459 and the issue #1524. | ||||
|
||||
# 6. Optionally, insert a brief introduction for the vote PR, in the markdown format. | ||||
prBody: | | ||||
Currently, the bot looks through all commits on `main` that have landed in the last 12 months, and makes two lists: | ||||
|
||||
- a list of all the commit authors. | ||||
- a list of all the collaborators who are listed as reviewers in the commit message (i.e. folks who have approved the PR). | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would prefer we add a third option of asking @nodejs/security-wg to review the membership durations and then the TSC to implement their feedback. I for example would vote against reducing the duration since I feel like it has little security benefit and can alienate people but if I was convinced there would be actual security merit I'd be in favor. |
||||
|
||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: redundant whitespace
Suggested change
|
||||
The bot will open a PR to move a collaborator to emeritus if they don't appear in either of those lists. | ||||
This vote is to decide whether we want to reduce the timespan from 12 months to | ||||
9 months. | ||||
|
||||
# 7. Optionally, choose an id that will be used for the branch name as well as | ||||
# the vote folder name. If not supplied, a UUID will be used. | ||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: redundant whitespace