fix(votes): use GitHub handles in the JSON summary #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our automations rely on the GitHub handle to be present, not the name and email address. And since we are generating the summary ourselves, we can get rid on the dependency on `ghcommit` by generating the GraphQL query directly.
benjamingr
approved these changes
Jun 26, 2024
marco-ippolito
approved these changes
Jun 26, 2024
aduh95
commented
Jun 26, 2024
aduh95
commented
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our automations rely on the GitHub handle to be present, not the name and email address (e.g. in https://github.com/nodejs/TSC/blob/main/votes/2024-05-07-0.json, the automation considers that no one has voted, because it doesn't see any GitHub handle). And since we are generating the summary ourselves, we can get rid on the dependency on
ghcommitby generating the GraphQL query directly.