Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixup man-page generator #128

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Conversation

RedYetiDev
Copy link
Member

@RedYetiDev RedYetiDev commented Oct 21, 2024

Followup #125


Addresses the latest review + rewords the template a little bit for clarity from https://openjs-foundation.slack.com/archives/CVAMEJ4UV/p1729475894758189.


CC previous participants @ovflowd @AugustinMauroy @flakey5

@RedYetiDev RedYetiDev requested a review from a team as a code owner October 21, 2024 20:25
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nit, everything else LGTM!

src/generators/man-page/index.mjs Outdated Show resolved Hide resolved
@ovflowd ovflowd merged commit a504264 into nodejs:main Oct 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants