-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate away from 'master' as the jenkins CI controller node name #2971
Comments
@sxa Did you mean to open this in https://github.com/nodejs/build instead? |
Is there anything more needed than:
Is there any risk in doing this? |
Theorietcially it would depend if anything was explictly coded to 'master', although this is not likely to be aproblem given that
Based on the first of those, I'm pretty sure it would be safe for us. |
ok, then +1 lets pick a time and do it. |
This may have been done when I updated the CI servers in #2984. |
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made. |
What is the problem this feature will solve?
Remove all references to 'master' in jenkins. We have made the changein default branch name in all our repositories so to be consistent we should switch the name in jenkins too.
This is recommended by jenkins: https://www.jenkins.io/doc/book/managing/built-in-node-migration/
What is the feature you are proposing to solve the problem?
Click the migration button in jenkins to migrage from
master
tobuild-in
as the controller's node. I don't think we have any executors on the controller host, so I suspect this will have no impactLWhat alternatives have you considered?
Leaving it as-is and ignoring the warning :-)
The text was updated successfully, but these errors were encountered: