Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from 'master' as the jenkins CI controller node name #2971

Closed
sxa opened this issue Jun 21, 2022 · 6 comments
Closed

Migrate away from 'master' as the jenkins CI controller node name #2971

sxa opened this issue Jun 21, 2022 · 6 comments

Comments

@sxa
Copy link
Member

sxa commented Jun 21, 2022

What is the problem this feature will solve?

Remove all references to 'master' in jenkins. We have made the changein default branch name in all our repositories so to be consistent we should switch the name in jenkins too.
This is recommended by jenkins: https://www.jenkins.io/doc/book/managing/built-in-node-migration/

What is the feature you are proposing to solve the problem?

Click the migration button in jenkins to migrage from master to build-in as the controller's node. I don't think we have any executors on the controller host, so I suspect this will have no impactL

What alternatives have you considered?

Leaving it as-is and ignoring the warning :-)

@richardlau
Copy link
Member

@sxa Did you mean to open this in https://github.com/nodejs/build instead?

@sxa sxa transferred this issue from nodejs/node Jun 21, 2022
@mhdawson
Copy link
Member

Is there anything more needed than:

Click the migration button in jenkins to migrage from masger to build-in as the controller's node

Is there any risk in doing this?

@sxa
Copy link
Member Author

sxa commented Jun 23, 2022

Theorietcially it would depend if anything was explictly coded to 'master', although this is not likely to be aproblem given that

  1. Node does not have any executors on the built-in node anyway
  2. We could add the master label to another node if it became a problem

Based on the first of those, I'm pretty sure it would be safe for us.

@mhdawson
Copy link
Member

ok, then +1 lets pick a time and do it.

@richardlau
Copy link
Member

This may have been done when I updated the CI servers in #2984.

@github-actions
Copy link

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Jul 26, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants