Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: upgrade armv7l containers to Debian 11 #3582

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

targos
Copy link
Member

@targos targos commented Dec 7, 2023

Refs: #3499

@targos
Copy link
Member Author

targos commented Dec 7, 2023

@targos
Copy link
Member Author

targos commented Dec 7, 2023

Why do we have "fanned" jobs for armv7l? Compiling directly in the container seems to work fine?

@richardlau
Copy link
Member

Why do we have "fanned" jobs for armv7l? Compiling directly in the container seems to work fine?

In the release CI the armv7l builds are cross compiled so the fanned jobs are more representative of what we release. If we want to change the release builds to compile natively on armv7l then we'd need to pick a Linux distro to use -- we use RHEL 8 elsewhere for Linux but there's is no armv7l support in RHEL (only arm64)).

@targos
Copy link
Member Author

targos commented Dec 7, 2023

Ok I see. Is the test job I did enough to validate that it will (probably) work in cross-compiled tests?

@richardlau
Copy link
Member

Ok I see. Is the test job I did enough to validate that it will (probably) work in cross-compiled tests?

I think so... the only thing I cannot remember is whether we need to add the host key for the jenkins workspace machine that hosts the temporary binary git repository to known_hosts.

@targos
Copy link
Member Author

targos commented Dec 7, 2023

@targos
Copy link
Member Author

targos commented Dec 7, 2023

the only thing I cannot remember is whether we need to add the host key for the jenkins workspace machine that hosts the temporary binary git repository to known_hosts.

Fanned job passed, so I guess it's good?

@richardlau
Copy link
Member

the only thing I cannot remember is whether we need to add the host key for the jenkins workspace machine that hosts the temporary binary git repository to known_hosts.

Fanned job passed, so I guess it's good?

Yes, LGTM. Thanks for checking.

@targos targos merged commit f4ee98f into nodejs:main Dec 7, 2023
1 check passed
@targos targos deleted the armv7l-debian11 branch December 7, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants