Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document how to apply a token with github-nodejs-bot #538

Closed
wants to merge 1 commit into from

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Jul 16, 2024

Document how to apply a fine-grained token with github-nodejs-bot's name.

After this landed, github-nodejs-bot tokens that are not fine-grained tokens like https://github.com/nodejs/docker-node/blob/main/.github/workflows/automatic-updates.yml#L28 may be updated to be fine-grained tokens.

@legendecas legendecas requested a review from a team as a code owner July 16, 2024 09:31
@legendecas legendecas force-pushed the apply-a-token branch 3 times, most recently from 31be506 to 3ef971a Compare July 16, 2024 09:46
APPLY_ACCESS_TOKEN.md Outdated Show resolved Hide resolved
APPLY_ACCESS_TOKEN.md Outdated Show resolved Hide resolved
APPLY_ACCESS_TOKEN.md Outdated Show resolved Hide resolved
APPLY_ACCESS_TOKEN.md Outdated Show resolved Hide resolved
APPLY_ACCESS_TOKEN.md Outdated Show resolved Hide resolved
APPLY_ACCESS_TOKEN.md Outdated Show resolved Hide resolved
APPLY_ACCESS_TOKEN.md Outdated Show resolved Hide resolved
@richardlau
Copy link
Member

I don't think this document belongs here -- this repository is for the code running the bot server and not for the bot user.
I think https://github.com/nodejs/admin/ would be a better place for this.

@legendecas
Copy link
Member Author

legendecas commented Jul 16, 2024

Well, this repo has the slogan of "@nodejs-github-bot's heart and soul" and the tokens are going to be used under the name of @nodejs-github-bot so I thought it would be easier to navigate here. And https://github.com/nodejs/admin/ is suitable for org-level requests, like creating a repo.

@richardlau
Copy link
Member

richardlau commented Jul 16, 2024

And https://github.com/nodejs/admin/ is suitable for org-level requests, like creating a repo.

I consider requesting a new token to be an org-level request. Maintaining the registry of tokens is certainly more the responsibility of the TSC rather than the github-bot team that maintains this repository. If the tokens are primarily for publishing to e.g. the npm registry, then arguably it's similar documentation to https://github.com/nodejs/admin/blob/main/npm-management.md.

@legendecas
Copy link
Member Author

Make sense. Closing in favor of nodejs/admin#894.

@legendecas legendecas closed this Jul 16, 2024
@legendecas legendecas deleted the apply-a-token branch July 20, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants