From 48588093ca4219b5f689acfc9ebea9e4c8c37663 Mon Sep 17 00:00:00 2001 From: Steve Repsher Date: Thu, 15 Feb 2024 09:17:46 -0500 Subject: [PATCH] Use clean installs from MPN (#298) --- .github/workflows/aiohttp.yml | 2 +- .github/workflows/ci.yaml | 6 +++--- README.md | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/aiohttp.yml b/.github/workflows/aiohttp.yml index 20f49ebd..37589191 100644 --- a/.github/workflows/aiohttp.yml +++ b/.github/workflows/aiohttp.yml @@ -35,7 +35,7 @@ jobs: key: ubuntu-latest-node-${{ hashFiles('vendor/llhttp/**/package-lock.json') }} restore-keys: ubuntu-latest-node- - name: Install llhttp dependencies - run: npm install --ignore-scripts + run: npm ci --ignore-scripts working-directory: vendor/llhttp - name: Build llhttp run: make diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index d34bf36f..9ad3c880 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -45,7 +45,7 @@ jobs: ${{ runner.os }}-node- - name: Install dependencies - run: npm install --ignore-scripts + run: npm ci --ignore-scripts - name: Build libllhttp.a shell: bash @@ -88,7 +88,7 @@ jobs: ${{ runner.os }}-node- - name: Install dependencies - run: npm install --ignore-scripts + run: npm ci --ignore-scripts # Custom script, because progress looks not good in CI - name: Run tests @@ -112,7 +112,7 @@ jobs: ${{ runner.os }}-node- - name: Install dependencies - run: npm install --ignore-scripts + run: npm ci --ignore-scripts - name: Run lint command run: npm run lint diff --git a/README.md b/README.md index 4960dbb5..28653aa0 100644 --- a/README.md +++ b/README.md @@ -397,7 +397,7 @@ With this flag this check is disabled. Make sure you have [Node.js](https://nodejs.org/), npm and npx installed. Then under project directory run: ```sh -npm install +npm ci make ``` @@ -451,7 +451,7 @@ _Note that using the git repo directly (e.g., via a git repo url and tag) will n 1. Ensure that `Clang` and `make` are in your system path. 2. Using Git Bash, clone the repo to your preferred location. -3. Cd into the cloned directory and run `npm install` +3. Cd into the cloned directory and run `npm ci` 5. Run `make` 6. Your `repo/build` directory should now have `libllhttp.a` and `libllhttp.so` static and dynamic libraries. 7. When building your executable, you can link to these libraries. Make sure to set the build folder as an include path when building so you can reference the declarations in `repo/build/llhttp.h`.