Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix zero length chunked response regression" #262

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Revert "Fix zero length chunked response regression" #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/native/http.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,7 @@ int llhttp__after_headers_complete(llhttp_t* parser, const char* p,
parser->status_code == 102 || /* Processing */
parser->status_code == 103 || /* Early Hints */
parser->status_code == 204 || /* No Content */
(parser->status_code == 304 &&
!(parser->flags & F_CHUNKED)) /* Not Modified */
parser->status_code == 304 /* Not Modified */
)
)
) {
Expand Down
36 changes: 16 additions & 20 deletions test/response/connection.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,8 +503,6 @@ off=94 message complete
HTTP/1.1 304 Not Modified
Transfer-Encoding: chunked

0

HTTP/1.1 200 OK
Transfer-Encoding: chunked

Expand All @@ -525,24 +523,22 @@ off=45 header_field complete
off=46 len=7 span[header_value]="chunked"
off=55 header_value complete
off=57 headers complete status=304 v=1/1 flags=208 content_length=0
off=60 chunk header len=0
off=62 chunk complete
off=62 message complete
off=62 reset
off=62 message begin
off=67 len=3 span[version]="1.1"
off=70 version complete
off=75 len=2 span[status]="OK"
off=79 status complete
off=79 len=17 span[header_field]="Transfer-Encoding"
off=97 header_field complete
off=98 len=7 span[header_value]="chunked"
off=107 header_value complete
off=109 headers complete status=200 v=1/1 flags=208 content_length=0
off=112 chunk header len=5
off=112 len=5 span[body]="hello"
off=119 chunk complete
off=122 chunk header len=0
off=57 message complete
off=57 reset
off=57 message begin
off=62 len=3 span[version]="1.1"
off=65 version complete
off=70 len=2 span[status]="OK"
off=74 status complete
off=74 len=17 span[header_field]="Transfer-Encoding"
off=92 header_field complete
off=93 len=7 span[header_value]="chunked"
off=102 header_value complete
off=104 headers complete status=200 v=1/1 flags=208 content_length=0
off=107 chunk header len=5
off=107 len=5 span[body]="hello"
off=114 chunk complete
off=117 chunk header len=0
```

## HTTP 100 first, then 400
Expand Down
27 changes: 0 additions & 27 deletions test/response/transfer-encoding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,30 +408,3 @@ off=67 len=1 span[body]=cr
off=68 len=1 span[body]=lf
```

## Zero length chunked can be parsed

<!-- meta={"type": "response" } -->
```http
HTTP/1.1 304 Not Modified
Transfer-Encoding: chunked

0


```

```log
off=0 message begin
off=5 len=3 span[version]="1.1"
off=8 version complete
off=13 len=12 span[status]="Not Modified"
off=27 status complete
off=27 len=17 span[header_field]="Transfer-Encoding"
off=45 header_field complete
off=46 len=7 span[header_value]="chunked"
off=55 header_value complete
off=57 headers complete status=304 v=1/1 flags=208 content_length=0
off=60 chunk header len=0
off=62 chunk complete
off=62 message complete
```