Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release proposal: v5.0.4 #1893

Closed
wants to merge 21 commits into from
Closed

Release proposal: v5.0.4 #1893

wants to merge 21 commits into from

Commits on Sep 26, 2019

  1. win,src: update win_delay_load_hook.cc to work with /clr

    Added "#pragma unmanaged" in win_delay_load_hook.cc to support clr
    
    PR-URL: #1819
    Reviewed-By: João Reis <reis@janeasystems.com>
    ipetrovic11 authored and rvagg committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    18d5c7c View commit details
    Browse the repository at this point in the history
  2. build: more Python 3 compat, replace compile with ast

    Make Python 3 compatiblity changes so the code works in both Python 2
    and Python 3.  Especially, make changes required because the compiler
    module was removed in Python 3 in favor of the ast module that exists
    in both Python 2 and Python 3.
    
    PR-URL: #1820
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Rod Vagg <r@va.gg>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    cclauss authored and rvagg committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    fa0ed4a View commit details
    Browse the repository at this point in the history
  3. build: import StringIO on Python 2 and Python 3

    This change supports access to StringIO on both Python 2 and Python 3
    
    PR-URL: #1836
    Reviewed-By: Rod Vagg <r@va.gg>
    Reviewed-By: João Reis <reis@janeasystems.com>
    cclauss authored and rvagg committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    da1b031 View commit details
    Browse the repository at this point in the history
  4. build: add test run Python 3.7 on macOS

    Refs: #1846
    PR-URL: #1843
    Reviewed-By: João Reis <reis@janeasystems.com>
    cclauss authored and rvagg committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    1267b4d View commit details
    Browse the repository at this point in the history
  5. test: accept Python 3 in test-find-python.js

    Fixes: #1826
    PR-URL: #1843
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Rod Vagg <r@va.gg>
    Reviewed-By: Matt Cowley <me@mattcowley.co.uk>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    joaocgreis authored and rvagg committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    2e24d0a View commit details
    Browse the repository at this point in the history
  6. gyp: Python 3 Windows fixes

    PR-URL: #1843
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Rod Vagg <r@va.gg>
    Reviewed-By: Matt Cowley <me@mattcowley.co.uk>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    joaocgreis authored and rvagg committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    8bcb1fb View commit details
    Browse the repository at this point in the history
  7. gyp: improve Windows+Cygwin compatibility

    Fixes: #1782
    PR-URL: #1817
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Rod Vagg <r@va.gg>
    Jose Quijada authored and rvagg committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    5553cd9 View commit details
    Browse the repository at this point in the history
  8. src,win: improve unmanaged handling

    Used scoped disabling of managed code handling to ensure no other
    files get affected.
    
    PR-URL: #1852
    Reviewed-By: João Reis <reis@janeasystems.com>
    peter-sabath authored and rvagg committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    1cb4708 View commit details
    Browse the repository at this point in the history
  9. gyp: use "is" when comparing to None

    PR-URL: #1860
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Rod Vagg <r@va.gg>
    MrMebelMan authored and rvagg committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    3f4972c View commit details
    Browse the repository at this point in the history
  10. gyp: assorted typo fixes

    PR-URL: #1853
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    XhmikosR authored and rvagg committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    06019ba View commit details
    Browse the repository at this point in the history
  11. gyp: rm semicolons (Python != JavaScript)

    PR-URL: #1858
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Rod Vagg <r@va.gg>
    MattIPv4 authored and rvagg committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    a976151 View commit details
    Browse the repository at this point in the history
  12. doc: fix missing argument for setting python path

    (accepted with minor modifications by rvagg)
    
    PR-URL: #1802
    Reviewed-By: Rod Vagg <rod@vagg.org>
    lagorsse authored and rvagg committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    785e527 View commit details
    Browse the repository at this point in the history
  13. lib: ignore non-critical os.userInfo() failures

    Fixes: #1834
    PR-URL: #1835
    rvagg committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    1186e89 View commit details
    Browse the repository at this point in the history
  14. lib: adding keep-alive header to download requests

    PR-URL: #1863
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Milad Farazmand authored and rvagg committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    aab118e View commit details
    Browse the repository at this point in the history
  15. bin: fix the usage instructions

    PR-URL: #1888
    Reviewed-By: Rod Vagg <rod@vagg.org>
    halitogunc authored and rvagg committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    5f3ed92 View commit details
    Browse the repository at this point in the history
  16. deps: update tar to 4.4.12

    Fixes: #1887
    PR-URL: #1889
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    mmarchini authored and rvagg committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    19dbc9a View commit details
    Browse the repository at this point in the history
  17. doc: update xcode install instructions to match Node's BUILDING

    PR-URL: #1884
    Reviewed-By: Rod Vagg <rod@vagg.org>
    ktrongnhan authored and rvagg committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    60a4083 View commit details
    Browse the repository at this point in the history
  18. gyp: decode stdout on Python 3

    PR-URL: #1890
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    cclauss authored and rvagg committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    f753c16 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2019

  1. gyp: more decode stdout on Python 3

    PR-URL: #1894
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    cclauss authored and rvagg committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    36638af View commit details
    Browse the repository at this point in the history
  2. gyp: modify XcodeVersion() to convert "4.2" to "0420" and "10.0" to "…

    …1000"
    
    Ref: nodejs/node-addon-api#445 (comment)
    PR-URL: #1895
    Reviewed-By: Rod Vagg <rod@vagg.org>
    cclauss authored and rvagg committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    1236869 View commit details
    Browse the repository at this point in the history
  3. v5.0.4: bump version and update changelog

    PR-URL: #1893
    rvagg committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    b887c40 View commit details
    Browse the repository at this point in the history