test_runner: avoid spread operator on arrays

PR-URL: #55143 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Sep 29, 2024 · 103b843 · 103b843
1 parent 56c1786
commit 103b843
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/internal/test_runner/runner.js b/lib/internal/test_runner/runner.js
@@ -158,7 +158,8 @@ function getRunArgs(path, { forceExit,
   ArrayPrototypePushApply(argv, execArgv);
 
   if (path === kIsolatedProcessName) {
-    ArrayPrototypePush(argv, '--test', ...ArrayPrototypeSlice(process.argv, 1));
+    ArrayPrototypePush(argv, '--test');
+    ArrayPrototypePushApply(argv, ArrayPrototypeSlice(process.argv, 1));
   } else {
     ArrayPrototypePush(argv, path);
   }

diff --git a/lib/internal/test_runner/test.js b/lib/internal/test_runner/test.js
@@ -8,6 +8,7 @@ const {
   ArrayPrototypeSome,
   ArrayPrototypeSplice,
   ArrayPrototypeUnshift,
+  ArrayPrototypeUnshiftApply,
   FunctionPrototype,
   MathMax,
   Number,
@@ -735,9 +736,9 @@ class Test extends AsyncResource {
 
   computeInheritedHooks() {
     if (this.parent.hooks.beforeEach.length > 0) {
-      ArrayPrototypeUnshift(
+      ArrayPrototypeUnshiftApply(
         this.hooks.beforeEach,
-        ...ArrayPrototypeSlice(this.parent.hooks.beforeEach),
+        ArrayPrototypeSlice(this.parent.hooks.beforeEach),
       );
     }