test: fix improper path to URL conversion

PR-URL: #54509 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Aug 30, 2024 · db8ae10 · db8ae10
1 parent fe4a92a
commit db8ae10
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/test/fixtures/permission/fs-read.js b/test/fixtures/permission/fs-read.js
@@ -5,10 +5,11 @@ const common = require('../../common');
 const assert = require('assert');
 const fs = require('fs');
 const path = require('path');
+const { pathToFileURL } = require('url');
 
 const blockedFile = process.env.BLOCKEDFILE;
 const bufferBlockedFile = Buffer.from(process.env.BLOCKEDFILE);
-const blockedFileURL = new URL('file://' + process.env.BLOCKEDFILE);
+const blockedFileURL = pathToFileURL(process.env.BLOCKEDFILE);
 const blockedFolder = process.env.BLOCKEDFOLDER;
 const allowedFolder = process.env.ALLOWEDFOLDER;
 const regularFile = __filename;

diff --git a/test/parallel/test-diagnostics-channel-module-import-error.js b/test/parallel/test-diagnostics-channel-module-import-error.js
@@ -2,6 +2,7 @@
 const common = require('../common');
 const assert = require('assert');
 const dc = require('diagnostics_channel');
+const { pathToFileURL } = require('url');
 
 const trace = dc.tracingChannel('module.import');
 const events = [];
@@ -30,10 +31,7 @@ trace.subscribe({
 import('does-not-exist').then(
   common.mustNotCall(),
   common.mustCall((error) => {
-    let expectedParentURL = module.filename.replaceAll('\\', '/');
-    expectedParentURL = common.isWindows ?
-      `file:///${expectedParentURL}` :
-      `file://${expectedParentURL}`;
+    const expectedParentURL = pathToFileURL(module.filename).href;
     // Verify order and contents of each event
     assert.deepStrictEqual(events, [
       {

diff --git a/test/parallel/test-diagnostics-channel-module-import.js b/test/parallel/test-diagnostics-channel-module-import.js
@@ -2,6 +2,7 @@
 const common = require('../common');
 const assert = require('assert');
 const dc = require('diagnostics_channel');
+const { pathToFileURL } = require('url');
 
 const trace = dc.tracingChannel('module.import');
 const events = [];
@@ -29,10 +30,7 @@ trace.subscribe({
 
 import('http').then(
   common.mustCall((result) => {
-    let expectedParentURL = module.filename.replaceAll('\\', '/');
-    expectedParentURL = common.isWindows ?
-      `file:///${expectedParentURL}` :
-      `file://${expectedParentURL}`;
+    const expectedParentURL = pathToFileURL(module.filename).href;
     // Verify order and contents of each event
     assert.deepStrictEqual(events, [
       {