Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue: stabilization of test runner code coverage #53924

Closed
2 of 3 tasks
cjihrig opened this issue Jul 18, 2024 · 2 comments
Closed
2 of 3 tasks

Tracking issue: stabilization of test runner code coverage #53924

cjihrig opened this issue Jul 18, 2024 · 2 comments
Labels
coverage Issues and PRs related to native coverage support. feature request Issues that request new features to be added to Node.js. test_runner Issues and PRs related to the test runner subsystem.

Comments

@cjihrig
Copy link
Contributor

cjihrig commented Jul 18, 2024 •
edited
Loading

What is the problem this feature will solve?

This issue is for tracking remaining work to stabilize code coverage in the test runner. When this feature originally shipped, it had documented limitations. Those have all been resolved.

Note that stabilization does not prevent future semver-minor additions or bug fixes.

Here is the minimum list of things that I think need to be resolved:

What is the feature you are proposing to solve the problem?

Eventually stabilizing test runner code coverage

What alternatives have you considered?

No response
@cjihrig cjihrig added the feature request Issues that request new features to be added to Node.js. label Jul 18, 2024
@cjihrig
Copy link
Contributor Author

cjihrig commented Jul 18, 2024

cc @MoLow @atlowChemi @benjamingr if you have other things to add to the list.

@RedYetiDev RedYetiDev added coverage Issues and PRs related to native coverage support. test_runner Issues and PRs related to the test runner subsystem. labels Jul 18, 2024
@cjihrig cjihrig mentioned this issue Jul 18, 2024
Merged
@atlowChemi atlowChemi mentioned this issue Jul 19, 2024
Merged
nodejs-github-bot pushed a commit that referenced this issue Jul 22, 2024
@cjihrig
test_runner: refactor coverage to pass in config options
ea837a0 
This commit updates the test runner's code coverage so that
coverage options are explicitly passed in instead of pulled
from command line options.

PR-URL: #53931
Refs: #53924
Refs: #53867
Refs: #53866
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Jul 28, 2024
@cjihrig @targos
test_runner: refactor coverage to pass in config options
280ca56 
This commit updates the test runner's code coverage so that
coverage options are explicitly passed in instead of pulled
from command line options.

PR-URL: #53931
Refs: #53924
Refs: #53867
Refs: #53866
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this issue Aug 5, 2024
@cjihrig @RafaelGSS
test_runner: refactor coverage to pass in config options
876e7b3 
This commit updates the test runner's code coverage so that
coverage options are explicitly passed in instead of pulled
from command line options.

PR-URL: #53931
Refs: #53924
Refs: #53867
Refs: #53866
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RedYetiDev RedYetiDev mentioned this issue Aug 6, 2024
Closed
2 tasks
nodejs-github-bot pushed a commit that referenced this issue Sep 20, 2024
@atlowChemi
test_runner: add support for coverage via run()
f79fd03 
PR-URL: #53937
Fixes: #53867
Refs: #53924
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@RedYetiDev
Copy link
Member

RedYetiDev commented Sep 20, 2024 •
edited
Loading

Okay, coverage is now supported via the run() API. In my opinion, this can be moved to stable once the following issues are resolved:

@cjihrig cjihrig closed this as completed Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
coverage Issues and PRs related to native coverage support. feature request Issues that request new features to be added to Node.js. test_runner Issues and PRs related to the test runner subsystem.
Projects
Node.js feature requests
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cjihrig @RedYetiDev