Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new env var UV_LOOP_ENABLE_IO_URING_SQPOLL #54858

Open
ronag opened this issue Sep 9, 2024 · 4 comments
Open

Add a new env var UV_LOOP_ENABLE_IO_URING_SQPOLL #54858

ronag opened this issue Sep 9, 2024 · 4 comments
Labels
libuv Issues and PRs related to the libuv dependency or the uv binding.

Comments

@ronag
Copy link
Member

ronag commented Sep 9, 2024

libuv disables SQPOLL by default and leaves it to the user/admin to enable/disable. However, I believe it's currently not possible to do this in node.

We should add a check for a UV_LOOP_ENABLE_IO_URING_SQPOLL env flag and call uv_loop_configure with the libuv flag UV_LOOP_ENABLE_IO_URING_SQPOLL.

Refs: libuv/libuv#4492

@ronag
Copy link
Member Author

ronag commented Sep 9, 2024

Related to our the current UV_USE_IO_URING env var.

@bnoordhuis
Copy link
Member

Not your var, our var :-)

Suggestion: prefix with NODE_ instead of UV_

@ronag
Copy link
Member Author

ronag commented Sep 9, 2024

@bnoordhuis wouldn't it be easier if libuv exposed this as some kind of UV_LOOP_ENABLE_IO_URING_SQPOLL_BY_DEFAULT env var?

@bnoordhuis
Copy link
Member

Maybe I'll add that someday but I'm in no particular rush. I don't really like ambient state like environment variables affecting the behavior of a library (programs? okay. libraries? not so much)

@RedYetiDev RedYetiDev added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libuv Issues and PRs related to the libuv dependency or the uv binding.
Projects
None yet
Development

No branches or pull requests

3 participants