Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared-libuv still requires deps/uv/uv.gyp #55787

Open
kapouer opened this issue Nov 8, 2024 · 2 comments · Fixed by #55789
Open

shared-libuv still requires deps/uv/uv.gyp #55787

kapouer opened this issue Nov 8, 2024 · 2 comments · Fixed by #55789

Comments

@kapouer
Copy link
Contributor

kapouer commented Nov 8, 2024

Version

Any recent version

Platform

Linux Debian

Subsystem

build

What steps will reproduce the bug?

Build with that flag
--shared-libuv
but without
deps/uv/*

How often does it reproduce? Is there a required condition?

n/a

What is the expected behavior? Why is that the expected behavior?

Without deps/uv/* and with --shared-libuv, it should build.

What do you see instead?

make[1]: *** No rule to make target 'deps/uv/uv.gyp', needed by 'out/Makefile'. Stop.

Additional information

It's not something really bad.
It would be nice if using shared-libuv, shared-zlib, shared-llhttp, didn't require the presence of gyp files.

@richardlau
Copy link
Member

@kapouer I think #55789 would fix this.

@kapouer
Copy link
Contributor Author

kapouer commented Nov 8, 2024

Yep ! If that works, that works.

@richardlau richardlau linked a pull request Nov 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants