Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: update note about building on smartOS 16 #25684

Closed
wants to merge 1 commit into from
Closed

meta: update note about building on smartOS 16 #25684

wants to merge 1 commit into from

Conversation

refack
Copy link
Contributor

@refack refack commented Jan 24, 2019 •
edited
Loading

Seems like note is outdated. ATM we run CI tests on smartOS 16 with GCC 4.9
https://github.com/nodejs/build/blob/383c09339779cb46a32c47909ed3cee3a1850001/ansible/roles/baselayout/vars/main.yml#L91-L94
and on smartOS17 with GCC7.
https://github.com/nodejs/build/blob/383c09339779cb46a32c47909ed3cee3a1850001/jenkins/scripts/VersionSelectorScript.groovy#L43-L48
I'm not sure if this note needs updating or complete removal.

/CC @nodejs/platform-smartos @nodejs/build

Refs: #25683

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2372/pipeline

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Jan 24, 2019
@refack refack mentioned this pull request Jan 24, 2019
Closed
@richardlau richardlau mentioned this pull request Jan 24, 2019
Closed
@richardlau
Copy link
Member

I'm not sure if this note needs updating or complete removal.

The same note is in Node.js 10. We can't currently run the prebuilt Node.js 10 binaries on SmartOS 16 on the CI: nodejs/build#1519

@richardlau richardlau mentioned this pull request Feb 17, 2019
Closed
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 18, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 4, 2019
@refack @BridgeAR
meta: update note about building on smartOS 16
000788e 
PR-URL: nodejs#25684
Refs: nodejs#25683
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

BridgeAR commented Mar 4, 2019

Landed in 000788e 🎉

@BridgeAR BridgeAR closed this Mar 4, 2019
BridgeAR pushed a commit that referenced this pull request Mar 4, 2019
@refack @BridgeAR
meta: update note about building on smartOS 16
74b9807 
PR-URL: #25684
Refs: #25683
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 5, 2019
@refack @BridgeAR
meta: update note about building on smartOS 16
b25694d 
PR-URL: #25684
Refs: #25683
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@refack refack deleted the update-building-smartos16 branch March 11, 2019 01:25
@refack refack restored the update-building-smartos16 branch March 11, 2019 15:32
@refack refack deleted the update-building-smartos16 branch April 14, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@refack @nodejs-github-bot @richardlau @BridgeAR @jasnell @Trott