v18.9.0 release proposal #44521
Merged
v18.9.0 release proposal #44521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid magic numbers in the code and use an OpenSSL constant instead. PR-URL: #44305 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
This function was introduced in 2684c90 as an internal helper function. The C++ implementation became a no-op in a57e2f2 when building against OpenSSL 1.1.0 (instead of OpenSSL 1.0.2), and eventually became a no-op in all supported OpenSSL versions in 970ce14. Finally, eb20447 removed the only call site of setFreeListLength (which was already a no-op at that point). Refs: #1529 Refs: #10859 Refs: #19794 Refs: #38116 PR-URL: #44300 Reviewed-By: Feng Yu <F3n67u@outlook.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Remove an unnecessary static_cast<char*>(). Use OPENSSL_secure_zalloc() instead of OPENSSL_secure_malloc() + memset(). Update the comment describing the function which predates support for OpenSSL's secure heap. PR-URL: #44302 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
md and mgf1_md are internal variable names and should not appear in JS error messages. Also include the invalid digest name in the error message. PR-URL: #44307 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The THROW_ERR_* functions interpret the first argument as a printf-like format string, which is problematic when it contains unsanitized user input. This typically happens when a printf-like function is used to produce the error message, which is then passed to a THROW_ERR_* function, which again interprets the error message as a format string. Fix such occurrences by properly formatting error messages using static format strings only, and in a single step. PR-URL: #44314 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #44322 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ian Sutherland <ian@iansutherland.ca> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #44351 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Instead of creating an object template for every ContextifyContext, we now create one object template that can be reused by all contexts. The native pointer can be obtained through an embdder pointer field in the creation context of the receiver in the interceptors, because the interceptors are only meant to be invoked on the global object of the contextified contexts. This makes the ContextifyContext template context-independent and therefore snapshotable. PR-URL: #44252 Refs: #44014 Refs: #37476 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Access to the global object from within a vm context is intercepted so it's slow, therefore we should try to avoid unnecessary access to it during the initialization of vm contexts. - Remove the Atomics.wake deletion as V8 now does not install it anymore. - Move the Intl.v8BreakIterator deletion into the snapshot. - Do not query the Object prototype if --disable-proto is not set. This should speed up the creation of vm contexts by about ~12%. PR-URL: #44252 Refs: #44014 Refs: #37476 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: #44319 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
By default, the debugger would query the specified inspector sever port to see if it's available before starting the server, and it would keep retrying until a timeout (previously 9999 ms) is reached. This timeout seems to be longer than necessary. This patch decreases the timeout to 3 seconds. PR-URL: #44359 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com>
Add basic tests for providers when using OpenSSL 3.x. PR-URL: #44148 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #44345 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Allows APM vendors to generate a diagnostic report without calling into JavaScript. Like, from their own message channels interrupting the isolate and generating a report on demand. PR-URL: #44255 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
symmetric_key_len_ is always equal to symmetric_key_.size(). Storing it separately is redundant and has no significant benefit. PR-URL: #44346 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
The test in `test/parallel/test-stream-writable-callback-twice.js` is duplicated in `test/parallel/test-stream-writable-write-cb-twice.js`. PR-URL: #44313 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Change the underlying type of DebugCategory to unsigned int so that it can be safely cast to an unsigned type without having to worry about negative values, removing the need for the DCHECK_GE statements. To fully benefit from type safety, remove DebugCategory::CATEGORY_COUNT and instead add a constexpr kDebugCategoryCount. Remove the second argument from EnabledDebugList::set_enabled() and EnabledDebugList::Parse() because it was always set to true. PR-URL: #44350 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #44377 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
sequential/test-child-process-execsync and parallel/test-child-process-spawnsync-timeout are both flaky on azure Windows machines, where it may take longer for Node.js to launch and receive output from child processes. These tests work by spawning a child processes that is supposed to sleep for a long time, but the option is configured so that Node.js would terminate them early when a shorter timeout is reached. Then the tests assert that the time taken for the whole thing is shorter than the specified sleep time (meaning the process don't actually get to sleep for that long). To make the tests less brittle on azure Windows, this patch raises the sleep times in those tests on Windows platform, so that the overhead can be taken into account there. PR-URL: #44375 Refs: nodejs/build#3014 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
PR-URL: #44367 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
This doesn't include the other tests for the result when running a specific test in WPT. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #44238 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
|
FYI: The build took more time than expected. I'll release it tomorrow. |
RafaelGSS
added a commit
that referenced
this pull request
Sep 7, 2022
Notable changes: * doc: * add daeyeon to collaborators (Daeyeon Jeong) #44355 * lib: * (SEMVER-MINOR) add diagnostics channel for process and worker (theanarkh) #44045 * os: * (SEMVER-MINOR) add machine method (theanarkh) #44416 * report: * (SEMVER-MINOR) expose report public native apis (Chengzhong Wu) #44255 * src: * (SEMVER-MINOR) expose environment RequestInterrupt api (Chengzhong Wu) #44362 * vm: * include vm context in the embedded snapshot (Joyee Cheung) #44252 PR-URL: #44521
RafaelGSS
force-pushed
the
v18.9.0-proposal
branch
from
0ae175d
to
d5fd6a0
Compare
ruyadorno
reviewed
Sep 7, 2022
Notable changes: * doc: * add daeyeon to collaborators (Daeyeon Jeong) #44355 * lib: * (SEMVER-MINOR) add diagnostics channel for process and worker (theanarkh) #44045 * os: * (SEMVER-MINOR) add machine method (theanarkh) #44416 * report: * (SEMVER-MINOR) expose report public native apis (Chengzhong Wu) #44255 * src: * (SEMVER-MINOR) expose environment RequestInterrupt api (Chengzhong Wu) #44362 * vm: * include vm context in the embedded snapshot (Joyee Cheung) #44252 PR-URL: #44521
RafaelGSS
force-pushed
the
v18.9.0-proposal
branch
from
d5fd6a0
to
9ae2af4
Compare
github-actions
bot
removed
the
request-ci
|
CI: https://ci.nodejs.org/job/node-test-pull-request/46471/ |
12 tasks
|
Release build on 9ae2af4: https://ci-release.nodejs.org/job/iojs+release/8740/ |
RafaelGSS
added a commit
that referenced
this pull request
Sep 8, 2022
Notable changes: * doc: * add daeyeon to collaborators (Daeyeon Jeong) #44355 * lib: * (SEMVER-MINOR) add diagnostics channel for process and worker (theanarkh) #44045 * os: * (SEMVER-MINOR) add machine method (theanarkh) #44416 * report: * (SEMVER-MINOR) expose report public native apis (Chengzhong Wu) #44255 * src: * (SEMVER-MINOR) expose environment RequestInterrupt api (Chengzhong Wu) #44362 * vm: * include vm context in the embedded snapshot (Joyee Cheung) #44252 PR-URL: #44521
RafaelGSS
added a commit
to RafaelGSS/nodejs.org
that referenced
this pull request
Sep 8, 2022
RafaelGSS
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Sep 8, 2022
This was referenced Sep 9, 2022
28 tasks
|
It looks like the merge of e27e709d3c accidentally removed some code necessary for systemtap/dtrace. |
|
You right. Looks like it conflicted with #43652. I'll apply a patch. |
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
Notable changes: * doc: * add daeyeon to collaborators (Daeyeon Jeong) nodejs#44355 * lib: * (SEMVER-MINOR) add diagnostics channel for process and worker (theanarkh) nodejs#44045 * os: * (SEMVER-MINOR) add machine method (theanarkh) nodejs#44416 * report: * (SEMVER-MINOR) expose report public native apis (Chengzhong Wu) nodejs#44255 * src: * (SEMVER-MINOR) expose environment RequestInterrupt api (Chengzhong Wu) nodejs#44362 * vm: * include vm context in the embedded snapshot (Joyee Cheung) nodejs#44252 PR-URL: nodejs#44521
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2022-09-08, Version 18.9.0 (Current), @RafaelGSS
Notable changes
Commits
e27e709d3c] - build: add --libdir flag to configure (Stephen Gallagher) #4436130da2b4d89] - build: added NINJA env to customize ninja binary (Jeff Dickey) #442933c5354869e] - cluster: fix cluster rr distribute error (theanarkh) #442025cefd02618] - crypto: handle invalid prepareAsymmetricKey JWK inputs (Filip Skokan) #44475c868e36385] - crypto: add digest name to INVALID_DIGEST errors (Tobias Nießen) #4446835cbe1ad85] - crypto: use actual option name in error message (Tobias Nießen) #44455c3dbe18e4c] - crypto: simplify control flow in HKDF (Tobias Nießen) #4427228781a1f7e] - crypto: improve RSA-PSS digest error messages (Tobias Nießen) #44307b1eafe14fd] - debugger: decrease timeout used to wait for the port to be free (Joyee Cheung) #443598ef5c40a83] - deps: update corepack to 0.14.0 (Node.js GitHub Bot) #44509cf19a79dfc] - deps: upgrade npm to 8.19.1 (npm team) #44486c5630ad1a7] - deps: V8: backport ff8d67c88449 (Michaël Zasso) #44423255e7fbd08] - deps: update Acorn to v8.8.0 (Michaël Zasso) #44437754d26a53e] - deps: patch V8 to 10.2.154.15 (Michaël Zasso) #442941b50ff2600] - deps: update icu tzdata to 2022b (Matías Zúñiga) #442831e451dca99] - deps: upgrade llhttp to 6.0.9 (Paolo Insogna) #4434457da3db522] - deps: update undici to 5.9.1 (Node.js GitHub Bot) #443191c87a7e8f6] - doc: add missing parenthesis in TLSSocket section (Tobias Nießen) #4451205006eddb2] - doc: do not use "Returns:" for crypto.constants (Tobias Nießen) #4448154b6ed58bc] - doc: use serial comma in addons docs (Tobias Nießen) #4448211452a97b3] - doc: add --update-assert-snapshot to node.1 (Colin Ihrig) #44429ae028e8ac3] - doc: improve assert.snapshot() docs (Colin Ihrig) #4442971c869688a] - doc: add missing imports in events sample code (Brian Evans) #4433792046e8027] - doc: apply scroll-margin-top to h2, h3 elements (metonym) #444143e6cde5931] - doc: fix spacing issue in--build-snapshothelp text (Shohei YOSHIDA) #444358e41dbb81b] - doc: mention cherry-pick edge-case on release (RafaelGSS) #44408cef30f9afc] - doc: note on release guide to updatemainbranch (Ruy Adorno) #4438421437f7a7f] - doc: fix release guide example consistency (Ruy Adorno) #44385ed52bd0a18] - doc: fix style of n-api.md (theanarkh) #4437765c1f4015f] - doc: add history for net.createServer() options (Luigi Pinca) #443264a0f750a6c] - doc: add daeyeon to collaborators (Daeyeon Jeong) #443558cc5556f76] - doc: fix typo in test runner code examples (Moshe Atlow) #44351b660b7467d] - doc,worker: document resourceLimits overrides (Keyhan Vakil) #439922ed3b30696] - inspector: prevent integer overflow in open() (Tobias Nießen) #44367b8f08e5e7e] - lib: codify findSourceMap return value when not found (Chengzhong Wu) #44397a86ef1ba3e] - lib: use safePromisealternatives when available (Antoine du Hamel) #43476e519ac7842] - meta: update AUTHORS (Node.js GitHub Bot) #44511c03f28b960] - meta: update AUTHORS (Node.js GitHub Bot) #44422ef08cbddac] - node-api: avoid calling virtual methods in base's dtor (Chengzhong Wu) #44424256340197c] - node-api: cleanup redundant static modifiers (Chengzhong Wu) #443016714736706] - (SEMVER-MINOR) os: add machine method (theanarkh) #44416807b1e5533] - report: get stack trace with cross origin contexts (Chengzhong Wu) #44398b17cc877d0] - report: fix missing section javascriptHeap on OOMError (Chengzhong Wu) #443981f23c17ae0] - (SEMVER-MINOR) report: expose report public native apis (Chengzhong Wu) #44255df259005d9] - report: add queue info for udp (theanarkh) #44345fc17b808c9] - src: rename misleading arg in ClientHelloParser (Tobias Nießen) #44500125ab7da2a] - src: improve error handling in CloneSSLCerts (Tobias Nießen) #44410aa34f7347b] - src: fix incorrect comments in crypto (Tobias Nießen) #4447018b720805f] - src: avoid casting std::trunc(... / ...) to size_t (Tobias Nießen) #444674331bbe2af] - (SEMVER-MINOR) src: expose environment RequestInterrupt api (Chengzhong Wu) #44362c5413a1146] - src: simplify enable_if logic ofToStringHelper::BaseConvert(Feng Yu) #44306dcc1cf4f4e] - src: add error handling touv_uptimecall (Juan José Arboleda) #44386fd611cc272] - src: remove base64_select_table and base64_table (Tobias Nießen) #444254776b4767b] - src: fix uv_err_name memory leak (theanarkh) #444218db2e66d3a] - src: make Endianness an enum class (Tobias Nießen) #44411048e440878] - src: fix ssize_t error from nghttp2.h (Darshan Sen) #44393dc1c95ede3] - src: trace fs async api (theanarkh) #440570f4e98ba2c] - src: restore context default IsCodeGenerationFromStringsAllowed value (Chengzhong Wu) #4432405fb650b54] - src: simplify and optimize GetOpenSSLVersion() (Tobias Nießen) #443957f16177f96] - src: useif constexprwhere appropriate (Anna Henningsen) #442912be8acad18] - src: simplify ECDH::GetCurves() (Tobias Nießen) #443093eb7918f8e] - src: make minor improvements to EnabledDebugList (Tobias Nießen) #4435088d9566593] - src: remove KeyObjectData::symmetric_key_len_ (Tobias Nießen) #44346768c9cb872] - src: fix multiple format string bugs (Tobias Nießen) #443146857ee8299] - src: make minor improvements to SecureBuffer (Tobias Nießen) #443022facf8b8e0] - stream: fix setting abort reason inReadableStream.pipeTo()(Daeyeon Jeong) #4441865134d696b] - stream: fixReadableStreamReader.releaseLock()(Daeyeon Jeong) #442924c33e5d4ce] - test: avoid race in file write stream handle tests (Joyee Cheung) #443800d77342a39] - test: style updates for assert.snapshot() (Colin Ihrig) #44429e36ed44b26] - test: deflake child process exec timeout tests (Joyee Cheung) #443900af15c71fb] - test: make the vm timeout escape tests more lenient (Joyee Cheung) #444330f071b800e] - test: split heap prof tests (Joyee Cheung) #443882dd88b8425] - test: fix multiple incorrect mustNotCall() uses (Tobias Nießen) #440224ae1f4990c] - test: split report OOM tests (Joyee Cheung) #443893a5fdacdc2] - test: fix WPT runner result (Daeyeon Jeong) #44238e001aafee3] - test: raise sleep times in child process tests (Joyee Cheung) #443758e2dcafc24] - test: remove duplicate test (Luigi Pinca) #44313c65d7fb1fa] - test: add OpenSSL 3.x providers test (Richard Lau) #4414811e9d6e173] - test: make tmpdir.js importable from esm (Geoffrey Booth) #44322a35c2f9ef4] - test_runner: fixduration_msto be milliseconds (Moshe Atlow) #444508175c65b4d] - test_runner: support programmatically running--test(Moshe Atlow) #442411cdccbc845] - tls: remove SecureContext setFreeListLength (Tobias Nießen) #4430070399166f3] - tls: use OpenSSL constant for client random size (Tobias Nießen) #443056fe189b62a] - tools: update lint-md-dependencies to rollup@2.79.0 (Node.js GitHub Bot) #445101e62bb14dd] - tools: fix typo inavoid-prototype-pollutionlint rule (Antoine du Hamel) #4444678c6827688] - tools: don't use f-strings in test.py (Santiago Gimeno) #44407443730c419] - tools: update doc to unist-util-visit@4.1.1 (Node.js GitHub Bot) #4437096df99375e] - tools: update eslint to 8.23.0 (Node.js GitHub Bot) #44419b6709544e9] - tools: refactoravoid-prototype-pollutionlint rule (Antoine du Hamel) #434768b0a4afcae] - tty: fix TypeError when stream is closed (Antoine du Hamel) #43803c4a45a93f3] - vm: avoid unnecessary property getter interceptor calls (Joyee Cheung) #44252736a04aa13] - vm: include vm context in the embedded snapshot (Joyee Cheung) #44252bce827e5d1] - vm: make ContextifyContext template context-independent (Joyee Cheung) #44252