Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update V8 to 11.4 #48029

Closed
wants to merge 12 commits into from
Closed

deps: update V8 to 11.4 #48029

wants to merge 12 commits into from

Commits on May 16, 2023

  1. deps: update V8 to 11.4.183.8

    @targos
    targos committed May 16, 2023
    Configuration menu
    Copy the full SHA
    77ac9bc View commit details
    Browse the repository at this point in the history

  2. build: reset embedder string to "-node.0"

    @targos
    targos committed May 16, 2023
    Configuration menu
    Copy the full SHA
    78e6dbb View commit details
    Browse the repository at this point in the history

  3. src: update NODE_MODULE_VERSION to 117 

    Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 11.4.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
    @targos
    targos committed May 16, 2023
    Configuration menu
    Copy the full SHA
    25aded8 View commit details
    Browse the repository at this point in the history

  4. deps: always define V8_EXPORT_PRIVATE as no-op 

    dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
    @targos
    targos committed May 16, 2023
    Configuration menu
    Copy the full SHA
    958931c View commit details
    Browse the repository at this point in the history

  5. deps: silence irrelevant V8 warning 

    PR-URL: nodejs#45579
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
    @targos
    targos committed May 16, 2023
    Configuration menu
    Copy the full SHA
    7bebfcd View commit details
    Browse the repository at this point in the history

  6. deps: patch V8 to support compilation on win-arm64

    @targos
    targos committed May 16, 2023
    Configuration menu
    Copy the full SHA
    9603655 View commit details
    Browse the repository at this point in the history

  7. deps: disable V8 concurrent sparkplug compilation 

    It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @targos
    targos committed May 16, 2023
    Configuration menu
    Copy the full SHA
    80942b3 View commit details
    Browse the repository at this point in the history

  8. tools: update V8 gypfiles for 11.4

    @targos
    targos committed May 16, 2023
    Configuration menu
    Copy the full SHA
    123369b View commit details
    Browse the repository at this point in the history

  9. tools: add new V8 headers to distribution

    @targos
    targos committed May 16, 2023
    Configuration menu
    Copy the full SHA
    c72a91b View commit details
    Browse the repository at this point in the history

  10. lib: update usage of always on Atomics API

    @targos
    targos committed May 16, 2023
    Configuration menu
    Copy the full SHA
    25539ea View commit details
    Browse the repository at this point in the history

  11. test: adapt debugger tests to V8 11.4 

    Accept a new `step` break message.
    @pfaffe @targos
    pfaffe authored and targos committed May 16, 2023
    Configuration menu
    Copy the full SHA
    61e265a View commit details
    Browse the repository at this point in the history

  12. test: update flag to disable SharedArrayBuffer 

    `--no-harmony-sharedarraybuffer` was removed from V8 but it's still
possible to disable the feature with `--enable-sharedarraybuffer-per-context`.
    @targos
    targos committed May 16, 2023
    Configuration menu
    Copy the full SHA
    174ca27 View commit details
    Browse the repository at this point in the history