Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update V8 to 11.5 #48456

Closed
wants to merge 14 commits into from
Closed

deps: update V8 to 11.5 #48456

wants to merge 14 commits into from

Commits on Jun 21, 2023

  1. deps: update V8 to 11.5.150.10

    @targos
    targos committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    0ddf2b3 View commit details
    Browse the repository at this point in the history

  2. build: reset embedder string to "-node.0"

    @targos
    targos committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    e8726f8 View commit details
    Browse the repository at this point in the history

  3. src: update NODE_MODULE_VERSION to 118 

    Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 11.5.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
    @targos
    targos committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    5801de2 View commit details
    Browse the repository at this point in the history

  4. deps: always define V8_EXPORT_PRIVATE as no-op 

    dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
    @targos
    targos committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    b3fd0cd View commit details
    Browse the repository at this point in the history

  5. deps: silence irrelevant V8 warning 

    PR-URL: nodejs#45579
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
    @targos
    targos committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    dc3c787 View commit details
    Browse the repository at this point in the history

  6. deps: disable V8 concurrent sparkplug compilation 

    It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs#47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @targos
    targos committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    5258be6 View commit details
    Browse the repository at this point in the history

  7. deps: V8: cherry-pick 15e31d629ac0 

    Original commit message:

    [win][msvc] fix cross-compilation for arm64

    Cross-compiling x64 to ARM64 on Windows fails with MSVC. The reason is
    the ProbeMemory function which uses asm() code prohibited in this case.
    This change adds conditionalizing on V8_TRAP_HANDLER_SUPPORTED thus
    removing the problematic parts of the code in MSVC cross-compilation.

    This extends https://chromium-review.googlesource.com/c/v8/v8/+/3964232
    in a way, as it wraps ProbeMemory usage inside of the "#ifdef
    V8_TRAP_HANDLER_VIA_SIMULATOR" blocks.

    This follows https://chromium-review.googlesource.com/c/v8/v8/+/4403215
    and https://chromium-review.googlesource.com/c/v8/v8/+/4489305 as a part
    of an effort to completely fix cross-compilation with MSVC.

    Change-Id: I59d9a995fbc8ee1cee2807429fd44d8043c178fb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4574697
    Reviewed-by: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
    Commit-Queue: Mark Seaborn <mseaborn@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#88147}

Refs: v8/v8@15e31d6
    @targos
    targos committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    f6c4436 View commit details
    Browse the repository at this point in the history

  8. tools: update V8 gypfiles for 11.4

    @targos
    targos committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    273686f View commit details
    Browse the repository at this point in the history

  9. tools: add new V8 headers to distribution

    @targos
    targos committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    fd29941 View commit details
    Browse the repository at this point in the history

  10. lib: update usage of always on Atomics API

    @targos
    targos committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    baa57f1 View commit details
    Browse the repository at this point in the history

  11. test: adapt debugger tests to V8 11.4 

    Accept a new `step` break message.
    @pfaffe @targos
    pfaffe authored and targos committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    cc27e4e View commit details
    Browse the repository at this point in the history

  12. test: update flag to disable SharedArrayBuffer 

    `--no-harmony-sharedarraybuffer` was removed from V8 but it's still
possible to disable the feature with `--enable-sharedarraybuffer-per-context`.
    @targos
    targos committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    ada4cc2 View commit details
    Browse the repository at this point in the history

  13. tools: update V8 gypfiles for 11.5

    @targos
    targos committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    83435a2 View commit details
    Browse the repository at this point in the history

  14. test: adapt test-fs-write to V8 internal changes

    @targos
    targos committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    a999c68 View commit details
    Browse the repository at this point in the history