Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: avoid draining platform tasks at FreeEnvironment #51290

Merged
merged 1 commit into from
Jan 8, 2024

Commits on Dec 28, 2023

  1. src: avoid draining platform tasks at FreeEnvironment

    At the point of `FreeEnvironment` and onwards, no JavaScript execution
    associated with the Environment should be triggered.
    
    Avoid draining platform tasks that can trigger JavaScript execution in
    `FreeEnvironment`. The holder of `node::Environment` should immediately
    call `node::MultiIsolatePlatform::UnregisterIsolate` and
    `v8::Isolate::Dispose` to cancel pending foreground tasks and join
    concurrent tasks after the environment was freed.
    
    `NodePlatform` can properly handle the case in `RunForegroundTask` when
    an Isolate out-lives its associated `node::Environment`.
    legendecas committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    beab806 View commit details
    Browse the repository at this point in the history