tools: fix riscv64 build failed #52888

luyahan · 2024-05-08T08:36:43Z

nodejs-github-bot · 2024-05-08T08:36:48Z

Review requested:

@nodejs/gyp
@nodejs/v8-update

sxa · 2024-05-10T16:08:31Z

I had a try with your branch with GCC10 from Ubuntu 20.04/riscv64 and run into an issue with a number of symbols when building the test code - is that expected and do you get the same failure? I don't think I've seen these before.

../deps/googletest/include/gtest/internal/gtest-port.h: In function 'int testing::internal::posix::RmDir(const char*)':
../deps/googletest/include/gtest/internal/gtest-port.h:2053:44: error: 'rmdir' was not declared in this scope; did you mean 'simdutf::internal::rmdir'?
../deps/googletest/include/gtest/internal/gtest-port.h: In function 'int testing::internal::posix::DoIsATTY(int)':
../deps/googletest/include/gtest/internal/gtest-port.h:2084:38: error: 'isatty' was not declared in this scope; did you mean 'simdutf::internal::isatty'?
../deps/googletest/include/gtest/internal/gtest-port.h: In function 'int testing::internal::posix::ChDir(const char*)':
../deps/googletest/include/gtest/internal/gtest-port.h:2113:44: error: 'chdir' was not declared in this scope; did you mean 'simdutf::internal::chdir'?
../deps/googletest/include/gtest/internal/gtest-port.h: In function 'int testing::internal::posix::Read(int, void*, unsigned int)':
../deps/googletest/include/gtest/internal/gtest-port.h:2135:27: error: 'read' was not declared in this scope; did you mean 'simdutf::internal::read'?
../deps/googletest/include/gtest/internal/gtest-port.h: In function 'int testing::internal::posix::Write(int, const void*, unsigned int)':
../deps/googletest/include/gtest/internal/gtest-port.h:2138:27: error: 'write' was not declared in this scope; did you mean 'simdutf::internal::write'?
../deps/googletest/include/gtest/internal/gtest-port.h: In function 'int testing::internal::posix::Close(int)':
../deps/googletest/include/gtest/internal/gtest-port.h:2140:35: error: 'close' was not declared in this scope; did you mean 'simdutf::internal::close'?

EDIT: I'm going to be away for the next 2½ weeks - so until June - so if I don't respond to any further queries on this, that will be why

andreas-schwab · 2024-05-23T13:00:10Z

Why does that check for host_arch=="arm64" or target_arch=="arm64"?

- Backport nodejs/node#52888 - Seems crash when building with gcc had fixed, use GCC again.

luyahan · 2024-06-19T08:38:34Z

Why does that check for host_arch=="arm64" or target_arch=="arm64"?

Thanks. I had fix this.

nodejs-github-bot · 2024-08-06T15:47:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/60910/

sxa · 2024-08-07T16:51:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/60910/

LGTM - three failures - all passed on first re-run. First two are marked flakey:

@luyahan Before I approve (it fixes the build failure for me on a recent gcc) is there a reason why this PR appears to add extra files into the x64 build as well? I would expect this fox to only be in riscv64 specific sections.

wojiushixiaobai · 2024-10-04T13:08:48Z

@luyahan
Hello,

can you add the repair code for the loong64 architecture?
loong64 also needs this patch.

Thanks you.

        ['v8_target_arch=="loong64"', {
          'sources': [
            '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn"  "\\"v8_base_without_compiler.*?v8_enable_wasm_gdb_remote_debugging.*?v8_current_cpu == \\"loong64\\".*?sources \\+= ")',
          ],
          'conditions': [
            ['v8_enable_webassembly==1', {
              'conditions': [
                ['(_toolset=="host" and host_arch=="arm64" or _toolset=="target" and target_arch=="arm64") or (_toolset=="host" and host_arch=="loong64" or _toolset=="target" and target_arch=="loong64") or (_toolset=="host" and host_arch=="x64" or _toolset=="target" and target_arch=="x64")', {
                  'sources': [
                    '<(V8_ROOT)/src/trap-handler/handler-inside-posix.cc',
                    '<(V8_ROOT)/src/trap-handler/handler-outside-posix.cc',
                  ],
                }],
                ['(_toolset=="host" and host_arch=="x64" or _toolset=="target" and target_arch=="x64") and (OS=="linux")', {
                  'sources': [
                    '<(V8_ROOT)/src/trap-handler/handler-outside-simulator.cc',
                  ],
                }],
              ],
            }],
          ],
        }],

Fix build failure on riscv64 since v22. Ref: nodejs#52888 Ref: nodejs#52678

Ref: nodejs/node#52888 Ref: nodejs/node#52678

tuler · 2024-10-24T21:03:45Z

Is the riscv build for 22 still broken waiting for this to be reviewed?

Ref: nodejs/node#52888 Ref: nodejs/node#52678

benz0li · 2024-11-09T06:23:01Z

@luyahan Before I approve (it fixes the build failure for me on a recent gcc) is there a reason why this PR appears to add extra files into the x64 build as well? I would expect this fox to only be in riscv64 specific sections.

@luyahan and @sxa Can you get this sorted out?

It would be great if Node.js supported Linux/RISC-V (64-bit) again.

davidlt · 2024-11-14T10:19:24Z

I had to pull this patch into Fedora/RISCV NodeJS 22 to get it building again.
http://fedora.riscv.rocks/koji/buildinfo?buildID=343396

Could someone review this patch to unblock NodeJS 22?

luyahan · 2024-11-14T11:12:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/60910/

LGTM - three failures - all passed on first re-run. First two are marked flakey:

https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu2204_sharedlibs_openssl31_x64/45075/testReport/(root)/benchmark/test_benchmark_crypto_/

https://ci.nodejs.org/job/node-test-commit-plinux/nodes=rhel8-ppc64le/54657/testReport/(root)/parallel/test_sqlite_/

https://ci.nodejs.org/job/node-test-commit-arm/nodes=ubuntu2004-arm64/53936/testReport/(root)/parallel/test_error_serdes_/

@luyahan Before I approve (it fixes the build failure for me on a recent gcc) is there a reason why this PR appears to add extra files into the x64 build as well? I would expect this fox to only be in riscv64 specific sections.

There have condition ['v8_target_arch=="riscv64"',, so it don't add file into x64 build.

((_toolset=="host" and host_arch=="x64" or _toolset=="target" and target_arch=="x64")

The condition will be effective after the pr #55848
When enable v8_simulator, v8_target_arch != target_arch.

luyahan · 2024-11-14T11:13:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/60910/

LGTM - three failures - all passed on first re-run. First two are marked flakey:

https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu2204_sharedlibs_openssl31_x64/45075/testReport/(root)/benchmark/test_benchmark_crypto_/

https://ci.nodejs.org/job/node-test-commit-plinux/nodes=rhel8-ppc64le/54657/testReport/(root)/parallel/test_sqlite_/

https://ci.nodejs.org/job/node-test-commit-arm/nodes=ubuntu2004-arm64/53936/testReport/(root)/parallel/test_error_serdes_/

@luyahan Before I approve (it fixes the build failure for me on a recent gcc) is there a reason why this PR appears to add extra files into the x64 build as well? I would expect this fox to only be in riscv64 specific sections.

Hi @sxa
Could you have time to review this pr again?

nodejs-github-bot · 2024-11-16T10:49:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63570/

sxa

LGTM 😁 (The PR tester above didn't complete properly but subsequent testing looks good)

nodejs-github-bot · 2024-11-18T05:19:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63613/

sxa · 2024-11-18T14:56:41Z

@luyahan Can you adjust the commit message as per the "Merging is blocked" notification above please?

richardlau · 2024-11-18T15:39:04Z

@luyahan Can you adjust the commit message as per the "Merging is blocked" notification above please?

You can ignore that -- the tooling for merging will take care of it.

nodejs-github-bot · 2024-11-18T15:41:24Z

Landed in bdaa898

nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels May 8, 2024

luyahan force-pushed the fix-failed branch 2 times, most recently from ff7cd6a to 2674676 Compare May 8, 2024 09:16

richardlau mentioned this pull request May 9, 2024

riscv64 build failed for v20.11.0 nodejs/unofficial-builds#106

Open

richardlau mentioned this pull request May 23, 2024

undefined reference to `v8::internal::trap_handler::RegisterDefaultTrapHandler()' #53115

Open

hack3ric added a commit to hack3ric/archriscv-packages that referenced this pull request May 26, 2024

updpatch: nodejs 22.2.0-1

e300622

- Backport nodejs/node#52888 - Seems crash when building with gcc had fixed, use GCC again.

hack3ric mentioned this pull request May 26, 2024

updpatch: nodejs 22.2.0-1 felixonmars/archriscv-packages#3789

Merged

hack3ric added a commit to hack3ric/archriscv-packages that referenced this pull request May 26, 2024

updpatch: nodejs 22.2.0-1

603a816

- Backport nodejs/node#52888 - Seems crash when building with gcc had fixed, use GCC again.

felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request May 26, 2024

updpatch: nodejs 22.2.0-1

bd8eef0

- Backport nodejs/node#52888 - Seems crash when building with gcc had fixed, use GCC again.

richardlau added the riscv64 Issues and PRs related to the riscv64 architecture. label Jun 11, 2024

luyahan force-pushed the fix-failed branch 2 times, most recently from 70499c9 to 1d34529 Compare June 19, 2024 08:37

kxxt mentioned this pull request Oct 3, 2024

[Regression] v8 wasm error when running yarn install with yarn v3+ riscv-forks/electron#3

Open

MingcongBai pushed a commit to AOSC-Tracking/node that referenced this pull request Oct 23, 2024

UPSTREAM: tools: fix riscv64 build failed

1613ecb

Fix build failure on riscv64 since v22. Ref: nodejs#52888 Ref: nodejs#52678

MingcongBai added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Oct 23, 2024

nodejs-22: (riscv64, backport) fix build

d54d530

Ref: nodejs/node#52888 Ref: nodejs/node#52678

MingcongBai added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Oct 30, 2024

nodejs-22: (riscv64, backport) fix build

fcdd8d1

Ref: nodejs/node#52888 Ref: nodejs/node#52678

MingcongBai added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Oct 30, 2024

nodejs-22: (riscv64, backport) fix build

7130525

Ref: nodejs/node#52888 Ref: nodejs/node#52678

benz0li mentioned this pull request Nov 9, 2024

Official RISC-V 64-bit release assets coder/code-server#6986

Closed

luyahan force-pushed the fix-failed branch 2 times, most recently from 01ed478 to 075dddc Compare November 14, 2024 10:52

tools: fix riscv64 build failed

3481754

luyahan force-pushed the fix-failed branch from 075dddc to 3481754 Compare November 14, 2024 11:05

sxa approved these changes Nov 17, 2024

View reviewed changes

richardlau approved these changes Nov 18, 2024

View reviewed changes

richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 18, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 18, 2024

nodejs-github-bot merged commit bdaa898 into nodejs:main Nov 18, 2024
52 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tools: fix riscv64 build failed #52888

tools: fix riscv64 build failed #52888

luyahan commented May 8, 2024 •

edited

Loading

nodejs-github-bot commented May 8, 2024

sxa commented May 10, 2024 •

edited

Loading

andreas-schwab commented May 23, 2024

luyahan commented Jun 19, 2024

nodejs-github-bot commented Aug 6, 2024

sxa commented Aug 7, 2024

wojiushixiaobai commented Oct 4, 2024 •

edited

Loading

tuler commented Oct 24, 2024

benz0li commented Nov 9, 2024

davidlt commented Nov 14, 2024

luyahan commented Nov 14, 2024 •

edited

Loading

luyahan commented Nov 14, 2024 •

edited

Loading

nodejs-github-bot commented Nov 16, 2024

sxa left a comment

nodejs-github-bot commented Nov 18, 2024

sxa commented Nov 18, 2024

richardlau commented Nov 18, 2024

nodejs-github-bot commented Nov 18, 2024

tools: fix riscv64 build failed #52888

tools: fix riscv64 build failed #52888

Conversation

luyahan commented May 8, 2024 • edited Loading

nodejs-github-bot commented May 8, 2024

sxa commented May 10, 2024 • edited Loading

andreas-schwab commented May 23, 2024

luyahan commented Jun 19, 2024

nodejs-github-bot commented Aug 6, 2024

sxa commented Aug 7, 2024

wojiushixiaobai commented Oct 4, 2024 • edited Loading

tuler commented Oct 24, 2024

benz0li commented Nov 9, 2024

davidlt commented Nov 14, 2024

luyahan commented Nov 14, 2024 • edited Loading

luyahan commented Nov 14, 2024 • edited Loading

nodejs-github-bot commented Nov 16, 2024

sxa left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Nov 18, 2024

sxa commented Nov 18, 2024

richardlau commented Nov 18, 2024

nodejs-github-bot commented Nov 18, 2024

luyahan commented May 8, 2024 •

edited

Loading

sxa commented May 10, 2024 •

edited

Loading

wojiushixiaobai commented Oct 4, 2024 •

edited

Loading

luyahan commented Nov 14, 2024 •

edited

Loading

luyahan commented Nov 14, 2024 •

edited

Loading