Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: add dotenv benchmark #54278

Merged
merged 6 commits into from
Sep 18, 2024
Merged

benchmark: add dotenv benchmark #54278

merged 6 commits into from
Sep 18, 2024

Conversation

RedYetiDev
Copy link
Member

@RedYetiDev RedYetiDev commented Aug 9, 2024 •
edited
Loading

This PR adds a benchmark for dotenv file parsing:

util/parse-env.js
util/parse-env.js n=30000: 57,033.66385773717

@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Aug 9, 2024
@RedYetiDev RedYetiDev added the dotenv Issues and PRs related to .env file parsing label Aug 9, 2024
H4ad
H4ad reviewed Aug 10, 2024
View reviewed changes
Copy link
Member

@H4ad H4ad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @anonrig This method is something that we can benchmark? Does it have any form of caching or something that could affect the benchmark?

benchmark/misc/dotenv.js Outdated Show resolved Hide resolved
@RedYetiDev RedYetiDev added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Aug 10, 2024
@RedYetiDev
Copy link
Member Author

@anonrig would you mind reviewing this PR?

anonrig
anonrig reviewed Sep 4, 2024
View reviewed changes
benchmark/misc/dotenv.js Outdated Show resolved Hide resolved
anonrig
anonrig reviewed Sep 4, 2024
View reviewed changes
benchmark/misc/dotenv.js Outdated Show resolved Hide resolved
benchmark/misc/dotenv.js Outdated Show resolved Hide resolved
anonrig
anonrig reviewed Sep 4, 2024
View reviewed changes
benchmark/util/parse-env.js Outdated Show resolved Hide resolved
@RedYetiDev
Copy link
Member Author

(Sorry @jasnell - only meant to request @anonrig 😅 )

@RedYetiDev
Copy link
Member Author

Can this land?

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 18, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 18, 2024
@nodejs-github-bot nodejs-github-bot merged commit 53cba82 into nodejs:main Sep 18, 2024
22 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 53cba82

targos pushed a commit that referenced this pull request Oct 4, 2024
@RedYetiDev @targos
benchmark: add dotenv benchmark
23b628d 
PR-URL: #54278
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@RedYetiDev @louwers
benchmark: add dotenv benchmark
3a3dd2f 
PR-URL: nodejs#54278
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit that referenced this pull request Nov 16, 2024
@RedYetiDev @marco-ippolito
benchmark: add dotenv benchmark
e99c5db 
PR-URL: #54278
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@marco-ippolito marco-ippolito mentioned this pull request Nov 16, 2024
Open
marco-ippolito pushed a commit that referenced this pull request Nov 17, 2024
@RedYetiDev @marco-ippolito
benchmark: add dotenv benchmark
0984910 
PR-URL: #54278
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H4ad H4ad H4ad approved these changes

@anonrig anonrig anonrig approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dotenv Issues and PRs related to .env file parsing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RedYetiDev @nodejs-github-bot @jasnell @anonrig @H4ad