process: add `process.features.typescript` #54295

RedYetiDev · 2024-08-10T00:15:02Z

Fixes #54294

nodejs-github-bot · 2024-08-10T00:15:07Z

Review requested:

@nodejs/startup

RedYetiDev · 2024-08-10T00:17:24Z

Drafting, as there may be a way to get the arg in CPP

codecov · 2024-08-10T01:29:25Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (d24c731) to head (74a8769).
Report is 74 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #54295   +/-   ##
=======================================
  Coverage   88.39%   88.40%           
=======================================
  Files         652      652           
  Lines      186568   186591   +23     
  Branches    36047    36050    +3     
=======================================
+ Hits       164924   164952   +28     
+ Misses      14915    14912    -3     
+ Partials     6729     6727    -2

Files with missing lines	Coverage Δ
lib/internal/bootstrap/node.js	`99.78% <100.00%> (+0.01%)`	⬆️

... and 25 files with indirect coverage changes

H4ad · 2024-08-10T01:59:38Z

Maybe process.features.stripTypes is not better?

Also, there's no other way to check if any flag is enabled? I know there is inside the codebase but I don't remember to see it exposed

RedYetiDev · 2024-08-10T02:06:33Z

Also, there's no other way to check if any flag is enabled? I know there is inside the codebase but I don't remember to see it exposed

It's pretty late where I am, but I'm going to investigate alternative approaches tomorrow

RedYetiDev · 2024-08-10T16:06:11Z

Maybe process.features.stripTypes is not better?

I feel like if more typescript support is added, E.G. #54283, it does more than just strip types.

test/es-module/test-typescript.mjs

lib/internal/bootstrap/node.js

marco-ippolito · 2024-08-12T06:36:11Z

since we have 2 levels of typescript support, instead of boolean it would be better to return { mode: "transform" // or strip-only }

silverwind · 2024-08-12T08:19:36Z

since we have 2 levels of typescript support, instead of boolean it would be better to return { mode: "transform" // or strip-only }

Hmm, not sure that would fit in process.features. In my case, I'm primarly after knowing whether the current process can load typescript, I wouldn't care about those modes as long as they both give typescript loading support.

lib/internal/bootstrap/node.js

legendecas · 2024-08-12T09:16:59Z

/cc @nodejs/typescript

lib/internal/bootstrap/node.js

anonrig

I don't think we should add this. This feature can easily be added as a userland module. I don't think we should add more attributes to global variables unless we have a compelling reason.

silverwind · 2024-08-14T08:06:16Z

I don't think we should add this. This feature can easily be added as a userland module. I don't think we should add more attributes to global variables unless we have a compelling reason.

Please demonstrate how one can do this in a future-proof way that continues to work once the flag is made the default. I see none.

marco-ippolito · 2024-08-20T14:13:25Z

I'm ok with this feature since otherwise user need to check process.argv or process.execArgv or NODE_OPTIONS.
We already have it for some other features so why not.

marcoippolito@marcos-MacBook-Pro amaro % node -p "process.features"
{
  inspector: true,
  debug: false,
  uv: true,
  ipv6: true,
  tls_alpn: true,
  tls_sni: true,
  tls_ocsp: true,
  tls: true,
  cached_builtins: [Getter]
}

But it needs to be a getter like cached_builtins and return an object

RedYetiDev · 2024-08-20T14:21:26Z

But it needs to be a getter like cached_builtins and return an object

I can update it to be a getter and return an object

RedYetiDev · 2024-08-20T15:33:20Z

Right now I have it like @legendecas suggested, that is, strip when --experimental-strip-types and transform when --experimental-transform-types, would you prefer your suggestion:

{ mode: "transform" // or strip-only }

lib/internal/bootstrap/node.js

RedYetiDev · 2024-10-01T11:53:52Z

Do I need to rebase to resolve the github CI failures, or can this land without them?

richardlau · 2024-10-01T11:55:23Z

Do I need to rebase to resolve the github CI failures, or can this land without them?

Unfortunately, yes, you will need to rebase.

nodejs-github-bot · 2024-10-02T02:22:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62887/

RedYetiDev · 2024-10-02T02:40:56Z

This needs yet another rebase 😭

nodejs-github-bot · 2024-10-02T16:23:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62897/

PR-URL: #54897 Refs: #54295 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

nodejs-github-bot · 2024-10-05T06:17:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62924/

nodejs-github-bot · 2024-10-05T07:08:13Z

Landed in bbdfeeb

PR-URL: #54295 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Notable changes: crypto: * (SEMVER-MINOR) add `KeyObject.prototype.toCryptoKey` (Filip Skokan) #55262 * (SEMVER-MINOR) add Date fields for `validTo` and `validFrom` (Andrew Moon) #54159 doc: * add abmusse to collaborators (Abdirahim Musse) #55086 http2: * (SEMVER-MINOR) expose `nghttp2_option_set_stream_reset_rate_limit` as an option (Maël Nison) #54875 lib: * (SEMVER-MINOR) propagate aborted state to dependent signals before firing events (jazelly) #54826 module: * (SEMVER-MINOR) support loading entrypoint as url (RedYetiDev) #54933 * (SEMVER-MINOR) implement the `"module-sync"` exports condition (Joyee Cheung) #54648 * (SEMVER-MINOR) implement `flushCompileCache()` (Joyee Cheung) #54971 * (SEMVER-MINOR) throw when invalid argument is passed to `enableCompileCache()` (Joyee Cheung) #54971 * (SEMVER-MINOR) write compile cache to temporary file and then rename it (Joyee Cheung) #54971 process: * (SEMVER-MINOR) add `process.features.require_module` (Joyee Cheung) #55241 * (SEMVER-MINOR) add `process.features.typescript` (Aviv Keller) #54295 src: * mark `node --run` as stable (Yagiz Nizipli) #53763 test_runner: * (SEMVER-MINOR) support custom arguments in `run()` (Aviv Keller) #55126 * (SEMVER-MINOR) add `'test:summary'` event (Colin Ihrig) #54851 * (SEMVER-MINOR) add support for coverage via `run()` (Chemi Atlow) #53937 worker: * (SEMVER-MINOR) add `markAsUncloneable` api (Jason Zhang) #55234 PR-URL: #55343

PR-URL: nodejs#54897 Refs: nodejs#54295 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: nodejs#54295 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Notable changes: crypto: * (SEMVER-MINOR) add `KeyObject.prototype.toCryptoKey` (Filip Skokan) nodejs#55262 * (SEMVER-MINOR) add Date fields for `validTo` and `validFrom` (Andrew Moon) nodejs#54159 doc: * add abmusse to collaborators (Abdirahim Musse) nodejs#55086 http2: * (SEMVER-MINOR) expose `nghttp2_option_set_stream_reset_rate_limit` as an option (Maël Nison) nodejs#54875 lib: * (SEMVER-MINOR) propagate aborted state to dependent signals before firing events (jazelly) nodejs#54826 module: * (SEMVER-MINOR) support loading entrypoint as url (RedYetiDev) nodejs#54933 * (SEMVER-MINOR) implement the `"module-sync"` exports condition (Joyee Cheung) nodejs#54648 * (SEMVER-MINOR) implement `flushCompileCache()` (Joyee Cheung) nodejs#54971 * (SEMVER-MINOR) throw when invalid argument is passed to `enableCompileCache()` (Joyee Cheung) nodejs#54971 * (SEMVER-MINOR) write compile cache to temporary file and then rename it (Joyee Cheung) nodejs#54971 process: * (SEMVER-MINOR) add `process.features.require_module` (Joyee Cheung) nodejs#55241 * (SEMVER-MINOR) add `process.features.typescript` (Aviv Keller) nodejs#54295 src: * mark `node --run` as stable (Yagiz Nizipli) nodejs#53763 test_runner: * (SEMVER-MINOR) support custom arguments in `run()` (Aviv Keller) nodejs#55126 * (SEMVER-MINOR) add `'test:summary'` event (Colin Ihrig) nodejs#54851 * (SEMVER-MINOR) add support for coverage via `run()` (Chemi Atlow) nodejs#53937 worker: * (SEMVER-MINOR) add `markAsUncloneable` api (Jason Zhang) nodejs#55234 PR-URL: nodejs#55343

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 10, 2024

RedYetiDev marked this pull request as draft August 10, 2024 00:15

RedYetiDev force-pushed the process-typescript branch from 7c8b50f to 1b1e197 Compare August 10, 2024 16:06

RedYetiDev added process Issues and PRs related to the process subsystem. strip-types Issues or PRs related to strip-types support labels Aug 10, 2024

RedYetiDev marked this pull request as ready for review August 10, 2024 16:07

theoludwig reviewed Aug 10, 2024

View reviewed changes

test/es-module/test-typescript.mjs Outdated Show resolved Hide resolved

RedYetiDev force-pushed the process-typescript branch from 1b1e197 to 4009a2f Compare August 10, 2024 16:57

anonrig reviewed Aug 10, 2024

View reviewed changes

lib/internal/bootstrap/node.js Outdated Show resolved Hide resolved

jasnell approved these changes Aug 11, 2024

View reviewed changes

legendecas reviewed Aug 12, 2024

View reviewed changes

lib/internal/bootstrap/node.js Show resolved Hide resolved

legendecas reviewed Aug 12, 2024

View reviewed changes

lib/internal/bootstrap/node.js Outdated Show resolved Hide resolved

anonrig requested changes Aug 14, 2024

View reviewed changes

RedYetiDev force-pushed the process-typescript branch from 4009a2f to 9bab1b4 Compare August 20, 2024 15:32

RedYetiDev requested a review from legendecas August 20, 2024 15:32

marco-ippolito reviewed Aug 20, 2024

View reviewed changes

lib/internal/bootstrap/node.js Outdated Show resolved Hide resolved

RedYetiDev force-pushed the process-typescript branch from 33f18ef to 0c6b543 Compare October 1, 2024 20:06

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2024

RedYetiDev added 2 commits October 2, 2024 10:21

process: add process.features.typescript

3317be7

fixup! process: add process.features.typescript

74a8769

RedYetiDev force-pushed the process-typescript branch from 0c6b543 to 74a8769 Compare October 2, 2024 14:21

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2024

marco-ippolito approved these changes Oct 5, 2024

View reviewed changes

marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2024

nodejs-github-bot merged commit bbdfeeb into nodejs:main Oct 5, 2024
59 checks passed

aduh95 mentioned this pull request Oct 9, 2024

V22.10.0 proposal #55343

Merged

aduh95 added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

process: add `process.features.typescript` #54295

process: add `process.features.typescript` #54295

RedYetiDev commented Aug 10, 2024

nodejs-github-bot commented Aug 10, 2024

RedYetiDev commented Aug 10, 2024

codecov bot commented Aug 10, 2024 •

edited

Loading

H4ad commented Aug 10, 2024

RedYetiDev commented Aug 10, 2024

RedYetiDev commented Aug 10, 2024

marco-ippolito commented Aug 12, 2024

silverwind commented Aug 12, 2024

legendecas commented Aug 12, 2024

anonrig left a comment •

edited

Loading

silverwind commented Aug 14, 2024

marco-ippolito commented Aug 20, 2024 •

edited

Loading

RedYetiDev commented Aug 20, 2024

RedYetiDev commented Aug 20, 2024 •

edited

Loading

RedYetiDev commented Oct 1, 2024

richardlau commented Oct 1, 2024

nodejs-github-bot commented Oct 2, 2024

RedYetiDev commented Oct 2, 2024

nodejs-github-bot commented Oct 2, 2024

nodejs-github-bot commented Oct 5, 2024

nodejs-github-bot commented Oct 5, 2024

process: add process.features.typescript #54295

process: add process.features.typescript #54295

Conversation

RedYetiDev commented Aug 10, 2024

nodejs-github-bot commented Aug 10, 2024

RedYetiDev commented Aug 10, 2024

codecov bot commented Aug 10, 2024 • edited Loading

Codecov Report

H4ad commented Aug 10, 2024

RedYetiDev commented Aug 10, 2024

RedYetiDev commented Aug 10, 2024

marco-ippolito commented Aug 12, 2024

silverwind commented Aug 12, 2024

legendecas commented Aug 12, 2024

anonrig left a comment • edited Loading

Choose a reason for hiding this comment

silverwind commented Aug 14, 2024

marco-ippolito commented Aug 20, 2024 • edited Loading

RedYetiDev commented Aug 20, 2024

RedYetiDev commented Aug 20, 2024 • edited Loading

RedYetiDev commented Oct 1, 2024

richardlau commented Oct 1, 2024

nodejs-github-bot commented Oct 2, 2024

RedYetiDev commented Oct 2, 2024

nodejs-github-bot commented Oct 2, 2024

nodejs-github-bot commented Oct 5, 2024

nodejs-github-bot commented Oct 5, 2024

process: add `process.features.typescript` #54295

process: add `process.features.typescript` #54295

codecov bot commented Aug 10, 2024 •

edited

Loading

anonrig left a comment •

edited

Loading

marco-ippolito commented Aug 20, 2024 •

edited

Loading

RedYetiDev commented Aug 20, 2024 •

edited

Loading