Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timers: document ref option for scheduler.wait #54605

Merged
merged 1 commit into from
Sep 2, 2024
Merged

timers: document ref option for scheduler.wait #54605

merged 1 commit into from
Sep 2, 2024
+12 −13

Conversation

ShogunPanda
Copy link
Contributor

Follow-up of #54404.
See: #54404 (comment) and #54404 (comment)

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Aug 28, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.34%. Comparing base (0b3ae01) to head (c875a81).
Report is 49 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54605      +/-   ##
==========================================
+ Coverage   87.32%   87.34%   +0.01%     
==========================================
  Files         649      649              
  Lines      182570   182566       -4     
  Branches    35026    35030       +4     
==========================================
+ Hits       159432   159456      +24     
+ Misses      16406    16389      -17     
+ Partials     6732     6721      -11
Files with missing lines Coverage Δ
lib/timers/promises.js 98.31% <100.00%> (-0.03%) ⬇️

... and 24 files with indirect coverage changes

aduh95
aduh95 approved these changes Aug 28, 2024
View reviewed changes
doc/api/timers.md Show resolved Hide resolved
@ShogunPanda ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 30, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 30, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61686/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61693/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61696/

@jakecastelli jakecastelli added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 31, 2024
@ShogunPanda ShogunPanda added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 2, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 2, 2024
@nodejs-github-bot nodejs-github-bot merged commit 294ae14 into nodejs:main Sep 2, 2024
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 294ae14

@ShogunPanda ShogunPanda deleted the timers-followup branch September 2, 2024 06:58
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@ShogunPanda @aduh95
timers: document ref option for scheduler.wait
b3d567a 
PR-URL: #54605
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Merged
targos pushed a commit that referenced this pull request Sep 22, 2024
@ShogunPanda @targos
timers: document ref option for scheduler.wait
38c3aaf 
PR-URL: #54605
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
targos pushed a commit that referenced this pull request Sep 26, 2024
@ShogunPanda @targos
timers: document ref option for scheduler.wait
d75904e 
PR-URL: #54605
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@targos targos mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShogunPanda @nodejs-github-bot @aduh95 @jakecastelli