Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: remove redudant code from eslint require rule #54892

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tools: remove redudant code from eslint require rule #54892

wants to merge 1 commit into from
+22 −35

Conversation

RedYetiDev
Copy link
Member

Review note:
I'm not a fan of the @author syntax. I edited the file, so I added my entry, but I'd prefer to remove it entirely.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 12, 2024
aduh95
aduh95 reviewed Sep 12, 2024
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some tests for this rule?

@RedYetiDev
Copy link
Member Author

RedYetiDev commented Sep 12, 2024 •
edited
Loading

Could we add some tests for this rule?

Shouldn't that be done in a separate PR? See test/parallel/test-eslint-duplicate-requires.js

@RedYetiDev RedYetiDev mentioned this pull request Sep 15, 2024
Closed
@RedYetiDev
Copy link
Member Author

Does this need a CI to land? It doesn't really change anything that would need testing, but there is a test for this rule... so?

@RedYetiDev RedYetiDev mentioned this pull request Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RedYetiDev @jasnell @aduh95 @nodejs-github-bot