Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v22.9.0 proposal #54966

Merged
merged 162 commits into from
Sep 17, 2024
Merged

v22.9.0 proposal #54966

merged 162 commits into from
Sep 17, 2024

Conversation

RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS commented Sep 16, 2024

2024-09-17, Version 22.9.0 (Current), @RafaelGSS

New API to retrieve execution Stack Trace

A new API getCallSite has been introduced to the util module. This API allows users
to retrieve the stacktrace of the current execution. Example:

const util = require('node:util');

function exampleFunction() {
  const callSites = util.getCallSite();

  console.log('Call Sites:');
  callSites.forEach((callSite, index) => {
    console.log(`CallSite ${index + 1}:`);
    console.log(`Function Name: ${callSite.functionName}`);
    console.log(`Script Name: ${callSite.scriptName}`);
    console.log(`Line Number: ${callSite.lineNumber}`);
    console.log(`Column Number: ${callSite.column}`);
  });
  // CallSite 1:
  // Function Name: exampleFunction
  // Script Name: /home/example.js
  // Line Number: 5
  // Column Number: 26

  // CallSite 2:
  // Function Name: anotherFunction
  // Script Name: /home/example.js
  // Line Number: 22
  // Column Number: 3

  // ...
}

// A function to simulate another stack layer
function anotherFunction() {
  exampleFunction();
}

anotherFunction();

Thanks to Rafael Gonzaga for making this work on #54380.

Disable V8 Maglev

We have seen several crashes/unexpected JS behaviors with maglev on v22
(which ships V8 v12.4). The bugs lie in the codegen so it would be difficult for
users to work around them or even figure out where the bugs are coming from.
Some bugs are fixed in the upstream while some others probably remain.

As v22 will get stuck with V8 v12.4 as LTS, it will be increasingly difficult to
backport patches for them even if the bugs are fixed. So disable it by default
on v22 to reduce the churn and troubles for users.

Thanks to Joyee Cheung for making this work on #54384

Exposes X509_V_FLAG_PARTIAL_CHAIN to tls.createSecureContext

This releases introduces a new option to the API tls.createSecureContext. For
now on users can use tls.createSecureContext({ allowPartialTrustChain: true })
to treat intermediate (non-self-signed) certificates in the trust CA certificate
list as trusted.

Thanks to Anna Henningsen for making this work on #54790

Other Notable Changes

  • [5c9599af5a] - src: create handle scope in FastInternalModuleStat (Joyee Cheung) #54384
  • [e2307d87e8] - (SEMVER-MINOR) stream: relocate the status checking code in the onwritecomplete (YoonSoo_Shin) #54032

Deprecations

  • [8433032948] - repl: doc-deprecate instantiating node:repl classes without new (Aviv Keller) #54842
  • [8c4c85cf31] - zlib: deprecate instantiating classes without new (Yagiz Nizipli) #54708

Commits

  • [027b0ffe84] - async_hooks: add an InactiveAsyncContextFrame class (Bryan English) #54510
  • [022767028e] - benchmark: --no-warnings to avoid DEP/ExpWarn log (Rafael Gonzaga) #54928
  • [af1988c147] - benchmark: add buffer.isAscii benchmark (RafaelGSS) #54740
  • [40c6849964] - benchmark: add buffer.isUtf8 bench (RafaelGSS) #54740
  • [237d7dfbde] - benchmark: add access async version to bench (Rafael Gonzaga) #54747
  • [ebe91db827] - benchmark: enhance dc publish benchmark (Rafael Gonzaga) #54745
  • [060164485b] - benchmark: add match and doesNotMatch bench (RafaelGSS) #54734
  • [2844180c7e] - benchmark: add rejects and doesNotReject bench (RafaelGSS) #54734
  • [af7689ed02] - benchmark: add throws and doesNotThrow bench (RafaelGSS) #54734
  • [456a1fe222] - benchmark: add strictEqual and notStrictEqual bench (RafaelGSS) #54734
  • [721c63c858] - benchmark: adds groups to better separate benchmarks (Giovanni Bucci) #54393
  • [68e45b406e] - benchmark,doc: add CPU scaling governor to perf (Rafael Gonzaga) #54723
  • [d19efd7a50] - benchmark,doc: mention bar.R to the list of scripts (Rafael Gonzaga) #54722
  • [1fb67afa2f] - buffer: fix out of range for toString (Jason Zhang) #54553
  • [85b5ed5d41] - buffer: re-enable Fast API for Buffer.write (Robert Nagy) #54526
  • [9a075279ec] - build: upgrade clang-format to v18 (Aviv Keller) #53957
  • [69ec9d8d2b] - build: fix conflicting V8 object print flags (Daeyeon Jeong) #54785
  • [948bba396c] - build: do not build with code cache for core coverage collection (Joyee Cheung) #54633
  • [6200cf4fb6] - build: don't store eslint locally (Aviv Keller) #54231
  • [3b5ed97fe9] - build: turn off -Wrestrict (Richard Lau) #54737
  • [e38e305a35] - build,win: enable clang-cl compilation (Stefan Stojanovic) #54655
  • [5bba0781b0] - crypto: reject dh,x25519,x448 in {Sign,Verify}Final (Huáng Jùnliàng) #53774
  • [3981853c00] - crypto: return a clearer error when loading an unsupported pkcs12 (Tim Perry) #54485
  • [02ac5376b9] - crypto: remove unused kHashTypes internal (Antoine du Hamel) #54627
  • [323d9da3c9] - deps: update cjs-module-lexer to 1.4.1 (Node.js GitHub Bot) #54846
  • [bf4bf7cc6b] - deps: update simdutf to 5.5.0 (Node.js GitHub Bot) #54434
  • [61047dd130] - deps: upgrade npm to 10.8.3 (npm team) #54619
  • [2351da5034] - deps: update cjs-module-lexer to 1.4.0 (Node.js GitHub Bot) #54713
  • [0659516823] - deps: allow amaro to be externalizable (Michael Dawson) #54646
  • [6a32645dbc] - deps: fix sign-compare warning in ncrypto (Cheng) #54624
  • [8f62f19197] - doc: fix broken Android building link (Niklas Wenzel) #54922
  • [440c256d76] - doc: add support link for aduh95 (Antoine du Hamel) #54866
  • [56aca2a1ca] - doc: run license-builder (github-actions[bot]) #54854
  • [8931f569c6] - doc: experimental flag for global accessible APIs (Chengzhong Wu) #54330
  • [6f8a6e9eb6] - doc: add ERR_INVALID_ADDRESS to errors.md (Aviv Keller) #54661
  • [c1b92e05e7] - doc: add support link for mcollina (Matteo Collina) #54786
  • [1def18122a] - doc: mark --conditions CLI flag as stable (Guy Bedford) #54209
  • [b8ae36b6c3] - doc: fix typo in recognizing-contributors (Tobias Nießen) #54822
  • [2c2ae80924] - doc: clarify --max-old-space-size and --max-semi-space-size units (Alexandre ABRIOUX) #54477
  • [5bd4be5ce7] - doc: replace --allow-fs-read by --allow-fs-write in related section (M1CK431) #54427
  • [c0f3e4603f] - doc: add support link for marco-ippolito (Marco Ippolito) #54789
  • [dc69eb8276] - doc: fix typo in module.md (Tobias Nießen) #54794
  • [de225f5db9] - doc: specify that preloaded modules affect subprocesses (Aviv Keller) #52939
  • [62b0007cbe] - doc: clarify expandedSQL behavior (Tobias Nießen) #54685
  • [1c7bdf95db] - doc: render type references in SQLite docs (Tobias Nießen) #54684
  • [5555095531] - doc: fix typo (Michael Dawson) #54640
  • [754baa4efa] - doc: fix webcrypto.md AES-GCM backticks (Filip Skokan) #54621
  • [5bfb4bcf45] - doc: add documentation about os.tmpdir() overrides (Joyee Cheung) #54613
  • [22d873208e] - doc, build: fixup build docs (Aviv Keller) #54899
  • [5e081a12b6] - doc, child_process: add esm snippets (Aviv Keller) #53616
  • [2b68c30a26] - doc, meta: fix broken link in onboarding.md (Aviv Keller) #54886
  • [a624002fff] - esm: throw ERR_REQUIRE_ESM instead of ERR_INTERNAL_ASSERTION (Antoine du Hamel) #54868
  • [31d4ef91ee] - esm: fix support for URL instances in import.meta.resolve (Antoine du Hamel) #54690
  • [40ba89e452] - esm: use Undici/fetch data: URL parser (Matthew Aitken) #54748
  • [93116dd7b1] - fs: translate error code properly in cpSync (Jason Zhang) #54906
  • [375cbb592e] - fs: refactor rimraf to avoid using primordials (Yagiz Nizipli) #54834
  • [ee89c3149e] - fs: respect dereference when copy symlink directory (Jason Zhang) #54732
  • [7123bf7ca4] - http: reduce likelihood of race conditions on keep-alive timeout (jazelly) #54863
  • [04ef3e4afd] - https: only use default ALPNProtocols when appropriate (Brian White) #54411
  • [dc5593ba1e] - lib: remove unnecessary async (jakecastelli) #54829
  • [2b9a6373da] - lib: make WeakRef safe in abort_controller (jazelly) #54791
  • [5f02e1b850] - lib: move Symbol[Async]Dispose polyfills to internal/util (Antoine du Hamel) #54853
  • [fc78ced7e4] - lib: convert signals to array before validation (Jason Zhang) #54714
  • [21fef34a53] - lib: add note about removing node:sys module (Rafael Gonzaga) #54743
  • [a37d805489] - (SEMVER-MINOR) lib: add util.getCallSite() API (Rafael Gonzaga) #54380
  • [2a1f56cce6] - lib: ensure no holey array in fixed_queue (Jason Zhang) #54537
  • [540b1dbaf6] - lib: refactor SubtleCrypto experimental warnings (Filip Skokan) #54620
  • [b59c8b88c7] - lib,src: use built-in array buffer detach, transfer (Yagiz Nizipli) #54837
  • [c1cc046de9] - meta: bump peter-evans/create-pull-request from 6.1.0 to 7.0.1 (dependabot[bot]) #54820
  • [82c08ef483] - meta: add Windows ARM64 to flaky-tests list (Aviv Keller) #54693
  • [df30e8efa1] - meta: ping @nodejs/performance on bench changes (Rafael Gonzaga) #54752
  • [bdd9fbb905] - meta: bump actions/setup-python from 5.1.1 to 5.2.0 (Rich Trott) #54691
  • [19574a8403] - meta: update sccache to v0.8.1 (Aviv Keller) #54720
  • [9ebcfb2b28] - meta: bump step-security/harden-runner from 2.9.0 to 2.9.1 (dependabot[bot]) #54704
  • [ea58feb959] - meta: bump actions/upload-artifact from 4.3.4 to 4.4.0 (dependabot[bot]) #54703
  • [c6bd9e443e] - meta: bump github/codeql-action from 3.25.15 to 3.26.6 (dependabot[bot]) #54702
  • [79b358af2e] - meta: fix links in SECURITY.md (Aviv Keller) #54696
  • [6c8a20d650] - meta: fix contributing codeowners (Aviv Keller) #54641
  • [b7284ed099] - module: do not warn for typeless package.json when there isn't one (Joyee Cheung) #54045
  • [ddd24a6e63] - node-api: add external buffer creation benchmark (Chengzhong Wu) #54877
  • [4a7576efae] - node-api: add support for UTF-8 and Latin-1 property keys (Mert Can Altin) #52984
  • [461e523498] - os: improve tmpdir performance (Yagiz Nizipli) #54709
  • [94fb7ab2e7] - path: remove StringPrototypeCharCodeAt from posix.extname (Aviv Keller) #54546
  • [67b1d4cb45] - repl: avoid interpreting 'npm' as a command when errors are recoverable (Shima Ryuhei) #54848
  • [8433032948] - repl: doc-deprecate instantiating node:repl classes without new (Aviv Keller) #54842
  • [7766349dd0] - sqlite: fix segfault in expandedSQL (Tobias Nießen) #54687
  • [4c1b98ba2b] - sqlite: remove unnecessary auto assignment (Tobias Nießen) #54686
  • [77d162adb6] - src: add --env-file-if-exists flag (Bosco Domingo) #53060
  • [424bdc03b4] - src: add Cleanable class to Environment (Gabriel Schulhof) #54880
  • [fbd08e3a9f] - src: switch crypto APIs to use Maybe<void> (James M Snell) #54775
  • [5e72bd3545] - src: eliminate ManagedEVPPkey (James M Snell) #54751
  • [97cbcfbb43] - src: fix unhandled error in structuredClone (Daeyeon Jeong) #54764
  • [b89cd8d19a] - src: move hkdf, scrypto, pbkdf2 impl to ncrypto (James M Snell) #54651
  • [5c9599af5a] - src: create handle scope in FastInternalModuleStat (Joyee Cheung) #54384
  • [e2307d87e8] - (SEMVER-MINOR) stream: relocate the status checking code in the onwritecomplete (YoonSoo_Shin) #54032
  • [ff54cabef6] - test: adjust test-tls-junk-server for OpenSSL32 (Michael Dawson) #54926
  • [23fb03beed] - test: remove duplicate skip AIX (Wuli) #54917
  • [2b5e70816a] - test: adjust tls test for OpenSSL32 (Michael Dawson) #54909
  • [cefa692dcb] - test: fix test-http2-socket-close.js (Hüseyin Açacak) #54900
  • [097f6d3e7e] - test: improve test-internal-fs-syncwritestream (Sunghoon) #54671
  • [ed736a689f] - test: deflake test-dns (Luigi Pinca) #54902
  • [bb4849f595] - test: fix test test-tls-dhe for OpenSSL32 (Michael Dawson) #54903
  • [d9264bceca] - test: use correct file naming syntax for util-parse-env (Aviv Keller) #53705
  • [115a7ca42a] - test: add missing await (Luigi Pinca) #54828
  • [7a1d633d77] - test: move more url tests to node:test (Yagiz Nizipli) #54636
  • [ee385d62b9] - test: strip color chars in test-runner-run (Giovanni Bucci) #54552
  • [2efec6221c] - test: deflake test-http2-misbehaving-multiplex (Luigi Pinca) #54872
  • [b198a91404] - test: remove dead code in test-http2-misbehaving-multiplex (Luigi Pinca) #54860
  • [194cb83f39] - test: reduce test-esm-loader-hooks-inspect-wait flakiness (Luigi Pinca) #54827
  • [4b53558e8b] - test: reduce the allocation size in test-worker-arraybuffer-zerofill (James M Snell) #54839
  • [c968d65d6d] - test: fix test-tls-client-mindhsize for OpenSSL32 (Michael Dawson) #54739
  • [b998bb0933] - test: remove need to make fs call for zlib test (Yagiz Nizipli) #54814
  • [f084ea2e01] - test: use platform timeout (jakecastelli) #54591
  • [b10e434cf3] - test: add platform timeout support for riscv64 (jakecastelli) #54591
  • [b875f2d7de] - test: reduce stack size for test-error-serdes (James M Snell) #54840
  • [d1a411480a] - test: reduce fs calls in test-fs-existssync-false (Yagiz Nizipli) #54815
  • [b96ee30a09] - test: use node:test in test-cli-syntax.bad (Aviv Keller) #54513
  • [5278b8b7a1] - test: move test-http-server-request-timeouts-mixed (James M Snell) #54841
  • [8345a60d3a] - test: fix Windows async-context-frame memory failure (Stephen Belanger) #54823
  • [cad404e1a1] - test: fix volatile for CauseSegfault with clang (Ivan Trubach) #54325
  • [41682c7286] - test: set test-http2-socket-close as flaky (Yagiz Nizipli) #54802
  • [1e1ac48711] - test: set test-worker-arraybuffer-zerofill as flaky (Yagiz Nizipli) #54802
  • [56238debff] - test: set test-runner-run-watch as flaky (Yagiz Nizipli) #54802
  • [8291de1540] - test: set test-http-server-request-timeouts-mixed as flaky (Yagiz Nizipli) #54802
  • [32d340e6b3] - test: set test-single-executable-application-empty as flaky (Yagiz Nizipli) #54802
  • [6a2da4c4ca] - test: set test-macos-app-sandbox as flaky (Yagiz Nizipli) #54802
  • [2f408847a0] - test: set test-fs-utimes as flaky (Yagiz Nizipli) #54802
  • [e3b7c40ffc] - test: set test-runner-run-watch as flaky (Yagiz Nizipli) #54802
  • [d2ede46946] - test: set test-sqlite-statement-sync as flaky (Yagiz Nizipli) #54802
  • [b9f3385808] - test: set test-writewrap as flaky (Yagiz Nizipli) #54802
  • [d55fec8f40] - test: set test-async-context-frame as flaky (Yagiz Nizipli) #54802
  • [3dfb525f3e] - test: set test-esm-loader-hooks-inspect-wait as flaky (Yagiz Nizipli) #54802
  • [b0458a88b4] - test: set test-http2-large-file as flaky (Yagiz Nizipli) #54802
  • [5f6f8757e5] - test: set test-runner-watch-mode-complex as flaky (Yagiz Nizipli) #54802
  • [4231af336d] - test: set test-performance-function as flaky (Yagiz Nizipli) #54802
  • [45ef2a868e] - test: set test-debugger-heap-profiler as flaky (Yagiz Nizipli) #54802
  • [b5137f6405] - test: fix test-process-load-env-file when path contains ' (Antoine du Hamel) #54511
  • [960116905a] - test: refactor fs-watch tests due to macOS issue (Santiago Gimeno) #54498
  • [f074d74bf3] - test: refactor test-esm-type-field-errors (Giovanni Bucci) #54368
  • [67e30deced] - test: move more zlib tests to node:test (Yagiz Nizipli) #54609
  • [fdb65111a3] - test: improve output of child process utilities (Joyee Cheung) #54622
  • [55a12a4190] - test,crypto: update WebCryptoAPI WPT (Filip Skokan) #54925
  • [de0f445a7f] - test_runner: reimplement assert.ok to allow stack parsing (Aviv Keller) #54776
  • [a52c199d9d] - (SEMVER-MINOR) test_runner: report coverage thresholds in test:coverage (Aviv Keller) #54813
  • [6552fddef5] - test_runner: update kPatterns (Pietro Marchini) #54728
  • [3396a4954d] - test_runner: detect only tests when isolation is off (Colin Ihrig) #54832
  • [021f59b6bc] - test_runner: apply filtering when tests begin (Colin Ihrig) #54832
  • [36da793350] - test_runner: allow --import with no isolation (Aviv Keller) #54697
  • [de73d1ee4b] - test_runner: improve code coverage cleanup (Colin Ihrig) #54856
  • [3d478728f2] - timers: avoid generating holey internal arrays (Gürgün Dayıoğlu) #54771
  • [b3d567ae0f] - timers: document ref option for scheduler.wait (Paolo Insogna) #54605
  • [c2bf0134ce] - (SEMVER-MINOR) tls: add allowPartialTrustChain flag (Anna Henningsen) #54790
  • [608a611132] - tools: add readability/fn_size to filter (Rafael Gonzaga) #54744
  • [93fab49099] - tools: add util scripts to land and rebase PRs (Antoine du Hamel) #54656
  • [d6df542ff8] - tools: remove readability/fn_size rule (Rafael Gonzaga) #54663
  • [689d127ee7] - typings: fix TypedArray to a global type (1ilsang) #54063
  • [071dff1d34] - typings: correct param type of SafePromisePrototypeFinally (Wuli) #54727
  • [5243e3240c] - Revert "v8: enable maglev on supported architectures" (Joyee Cheung) #54384
  • [ade9da5b3a] - vm: add vm proto property lookup test (Chengzhong Wu) #54606
  • [8385958b60] - zlib: add typings for better dx (Yagiz Nizipli) #54699
  • [8c4c85cf31] - zlib: deprecate instantiating classes without new (Yagiz Nizipli) #54708

joyeecheung and others added 30 commits September 5, 2024 22:10
It needs a handle scope for the context handle. Since the
FastApiCallbackOptions struct doesn't have isolate on it
in V8 12.4 on Node.js 22, use Isolate::TryGetCurrent() to
get to the isolate needed for the handle scope creation and
fallback to the slow callback if no isolate is entered.

PR-URL: #54384
Refs: #52797
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This reverts commit 1a5acd0.

Reason to revert: we have seen several crashes/unexpected JS behaviors
with maglev on v22 (which ships V8 v12.4). The bugs lie in the codegen
so it would be difficult for users to work around them or even figure
out where the bugs are coming from. Some bugs are fixed in the upstream
while some others probably remain. As v22 will get stuck with V8 v12.4
as LTS, it will be increasingly difficult to backport patches for them
even if the bugs are fixed. So disable it by default on v22 to reduce
the churn and troubles for users.

PR-URL: #54384
Refs: #52797
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
It was intended that warnings should only be emitted for an
existing package.json without a type. This fixes a confusing
warning telling users to update /package.json when there are
no package.json on the lookup path at all, like this:

[MODULE_TYPELESS_PACKAGE_JSON] Warning: ... parsed as an ES module
because module syntax was detected; to avoid the performance penalty
of syntax detection, add "type": "module" to /package.json

Drive-by: update the warning message to be clear about
reparsing and make it clear what's actionable.

PR-URL: #54045
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This documents the TMPDIR, TEMP and TMP overrides on different
platforms and that some operating systems set these by default.

PR-URL: #54613
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This gives a class prototype for AsyncContextFrame that contains the
required methods, so that when we swap the prototype,
ActiveAsyncContextFrame methods are used instead. Previously, the
methods were defined in AsyncContextFrame, so swapping the prototype
didn't swap those static methods.

Also, make the ActiveAsyncContextFrame extend from Map.

Fixes: #54503
PR-URL: #54510
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
PR-URL: #54620
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #54621
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
- Display command and options when it fails
- Keep the caller line at the top of the stack trace.

PR-URL: #54622
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
PR-URL: #54624
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
PR-URL: #54627
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
name used instructions differed that what is in the code

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #54640
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #54641
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #54609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
PR-URL: #54411
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #54663
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: #54537
Fixes: #54472
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: #54605
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
relocate the status checking code before verifying if the stream is
destroyed

PR-URL: #54032
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Render JavaScript types as such in the section "Type conversion between
JavaScript and SQLite".

PR-URL: #54684
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #54727
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: #54696
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.15 to 3.26.6.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@afb54ba...4dd1613)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: #54702
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.4 to 4.4.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@0b2256b...5076954)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: #54703
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.9.0 to 2.9.1.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](step-security/harden-runner@0d38121...5c7944e)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: #54704
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Fixes: #26425
Co-Authored-By: Yaman Kassir <mestery@protonmail.com>
PR-URL: #54393
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
PR-URL: #54737
Refs: #54736
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Add more test coverage on vm prototype properties lookup with
`in` operator and property access.

PR-URL: #54606
Refs: #54436
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #54720
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #54691
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #54722
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
mhdawson and others added 20 commits September 17, 2024 11:18
Refs: #53382

- OpenSSL32 has a minimum dh key size by 2048 by default.
- Adjust test to use larger 3072 key instead of 1024
  when OpenSSL32 is present.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #54903
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Prevent responses from being cached.

Fixes: #54124
PR-URL: #54902
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
A subtest about the behavior when `autoClose=false`.

PR-URL: #54671
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Co-authored-by: Jason Zhang <xzha4350@gmail.com>
PR-URL: #54829
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #54846
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #54699
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #53957
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: #54819
PR-URL: #54900
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Refs: #53382

Looks like test is forcing an error through bad data and
the error code we get is different for OpenSSL32. Adjust
test to cope with the variation across versions.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #54909
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #54917
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: #54922
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
This change ensures that 'npm' within JavaScript code is not mistakenly
interpreted as an npm command when the error is recoverable.
This allows 'npm' to be treated as expected in such scenarios.

Fixes: #54830
PR-URL: #54848
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
PR-URL: #54776
Refs: nodejs/help#4461
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #54925
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Refs: #53382

OpenSSL32 returns different error text. Looking through
the test it seems like the expected error text has been adjusted
for different OpenSSL versions in the past and what the test
is testing is not related to the error being returned.

Update test to allow for error returned by OpenSSL32

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #54926
Refs: #53382
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #54928
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
PR-URL: #54837
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Fixes: #50993
Refs: #51451

test: remove unnecessary comment

src: conform to style guidelines

src: change flag to `--env-file-optional`

test: revert automatic linter changes

doc: fix typos

src: change flag to `--env-file-if-exists`

src: refactor `env_file_data` and `GetEnvFileDataFromArgs`

test: clean up tests

src: print error when file not found

test: remove unnecessary extras
PR-URL: #53060
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
UV error code needs to be negative integer so it can be mapped
correctly. The filesystem error are positive integer, so we need to
handle it before throwing.

Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: #54906
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Notable changes:

lib:
  * (SEMVER-MINOR) add util.getCallSite() API (Rafael Gonzaga) #54380
repl:
  * doc-deprecate instantiating `node:repl` classes without `new` (Aviv Keller) #54842
src:
  * create handle scope in FastInternalModuleStat (Joyee Cheung) #54384
stream:
  * (SEMVER-MINOR) relocate the status checking code in the onwritecomplete (YoonSoo_Shin) #54032
tls:
  * (SEMVER-MINOR) add `allowPartialTrustChain` flag (Anna Henningsen) #54790
v8:
  * Revert "v8: enable maglev on supported architectures (Joyee Cheung) #54384

PR-URL: #54966
@RafaelGSS RafaelGSS merged commit 4631be0 into v22.x Sep 17, 2024
21 of 23 checks passed
@RafaelGSS RafaelGSS deleted the v22.9.0-proposal branch September 17, 2024 20:50
RafaelGSS added a commit that referenced this pull request Sep 17, 2024
RafaelGSS added a commit that referenced this pull request Sep 17, 2024
Notable changes:

lib:
  * (SEMVER-MINOR) add util.getCallSite() API (Rafael Gonzaga) #54380
repl:
  * doc-deprecate instantiating `node:repl` classes without `new` (Aviv Keller) #54842
src:
  * create handle scope in FastInternalModuleStat (Joyee Cheung) #54384
stream:
  * (SEMVER-MINOR) relocate the status checking code in the onwritecomplete (YoonSoo_Shin) #54032
tls:
  * (SEMVER-MINOR) add `allowPartialTrustChain` flag (Anna Henningsen) #54790
v8:
  * Revert "v8: enable maglev on supported architectures (Joyee Cheung) #54384

PR-URL: #54966
RafaelGSS added a commit to nodejs/nodejs.org that referenced this pull request Sep 17, 2024
RafaelGSS added a commit to nodejs/nodejs.org that referenced this pull request Sep 17, 2024
RafaelGSS added a commit to nodejs/nodejs.org that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. release Issues and PRs related to Node.js releases. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.