Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move test-http-max-sockets to parallel #54977

Merged
merged 1 commit into from
Sep 20, 2024
Merged

test: move test-http-max-sockets to parallel #54977

merged 1 commit into from
Sep 20, 2024

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Sep 17, 2024

As titled.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 17, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.06%. Comparing base (e21984b) to head (e46b44e).
Report is 96 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54977      +/-   ##
==========================================
+ Coverage   88.04%   88.06%   +0.01%     
==========================================
  Files         651      652       +1     
  Lines      183409   183546     +137     
  Branches    35828    35859      +31     
==========================================
+ Hits       161487   161639     +152     
+ Misses      15174    15152      -22     
- Partials     6748     6755       +7

see 51 files with indirect coverage changes

@lpinca lpinca added commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 18, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 18, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62539/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62545/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 19, 2024 •
edited by jakecastelli
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/62552/ 💚

@jakecastelli jakecastelli added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 19, 2024
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2024
@nodejs-github-bot nodejs-github-bot merged commit a6ed214 into nodejs:main Sep 20, 2024
69 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a6ed214

@lpinca lpinca deleted the move/test-http-max-socket-to-parallel branch September 22, 2024 05:53
targos pushed a commit that referenced this pull request Oct 4, 2024
@lpinca @targos
test: move test-http-max-sockets to parallel
5b012f5 
PR-URL: #54977
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@lpinca @louwers
test: move test-http-max-sockets to parallel
0ee7a59 
PR-URL: nodejs#54977
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Nov 16, 2024
@lpinca @marco-ippolito
test: move test-http-max-sockets to parallel
3738cea 
PR-URL: #54977
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Nov 16, 2024
Open
marco-ippolito pushed a commit that referenced this pull request Nov 17, 2024
@lpinca @marco-ippolito
test: move test-http-max-sockets to parallel
6f53c09 
PR-URL: #54977
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakecastelli jakecastelli jakecastelli approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpinca @nodejs-github-bot @targos @jakecastelli