-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: acknowledge signal
option in filehandle.createReadStream()
#55148
base: main
Are you sure you want to change the base?
fs: acknowledge signal
option in filehandle.createReadStream()
#55148
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55148 +/- ##
==========================================
- Coverage 88.25% 88.24% -0.01%
==========================================
Files 651 651
Lines 183898 183937 +39
Branches 35860 35860
==========================================
+ Hits 162298 162316 +18
- Misses 14893 14908 +15
- Partials 6707 6713 +6 |
Do we know when was this added? If so, could we add an entry in the YAML list? |
AFAICT it supported |
filehandle.createReadStream({ signal })
is supported but it was not documented nor tested.