Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: acknowledge signal option in filehandle.createReadStream() #55148

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LiviaMedeiros
Copy link
Contributor

filehandle.createReadStream({ signal }) is supported but it was not documented nor tested.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 28, 2024
@LiviaMedeiros LiviaMedeiros added the fs Issues and PRs related to the fs subsystem / file system. label Sep 28, 2024
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (b5fb2ff) to head (39bcf3c).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55148      +/-   ##
==========================================
- Coverage   88.25%   88.24%   -0.01%     
==========================================
  Files         651      651              
  Lines      183898   183937      +39     
  Branches    35860    35860              
==========================================
+ Hits       162298   162316      +18     
- Misses      14893    14908      +15     
- Partials     6707     6713       +6     

see 37 files with indirect coverage changes

@RedYetiDev RedYetiDev added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. labels Sep 28, 2024
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2024
@nodejs-github-bot
Copy link
Collaborator

@aduh95
Copy link
Contributor

aduh95 commented Sep 28, 2024

Do we know when was this added? If so, could we add an entry in the YAML list?

@LiviaMedeiros
Copy link
Contributor Author

AFAICT it supported signal since beginning when this function was added, so there's no need in separate entry.
Unless we want something like "officially supports since REPLACEME"

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants