Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add resource to internal module stat test #55157

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RafaelGSS
Copy link
Member

This was missing from #51344

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 28, 2024

Review requested:

  • @nodejs/security-wg

@RafaelGSS RafaelGSS added the permission Issues and PRs related to the Permission Model label Sep 28, 2024
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 28, 2024
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (3ac5b49) to head (ee3f3ac).
Report is 175 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55157      +/-   ##
==========================================
+ Coverage   88.07%   88.24%   +0.17%     
==========================================
  Files         652      651       -1     
  Lines      183653   183855     +202     
  Branches    35856    35825      -31     
==========================================
+ Hits       161753   162249     +496     
+ Misses      15146    14921     -225     
+ Partials     6754     6685      -69     

see 152 files with indirect coverage changes

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2024
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants