Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make test-loaders-workers-spawned less flaky #55172

Merged
merged 1 commit into from
Oct 8, 2024
Merged

test: make test-loaders-workers-spawned less flaky #55172

merged 1 commit into from
Oct 8, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 30, 2024

I've seen it fail on CI (e.g. https://github.com/nodejs/node/actions/runs/11084447570/job/30799766200), cannot reproduce locally. Calling console.log from both a worker and the main thread is always going to result in uncertain output, IMO it makes sense to considered the test passed as long as we got all of them, regardless of the order.

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 30, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (103b843) to head (7224c5d).
Report is 59 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55172      +/-   ##
==========================================
+ Coverage   88.23%   88.40%   +0.16%     
==========================================
  Files         651      652       +1     
  Lines      183863   186565    +2702     
  Branches    35824    36043     +219     
==========================================
+ Hits       162235   164924    +2689     
+ Misses      14932    14910      -22     
- Partials     6696     6731      +35

see 42 files with indirect coverage changes

@aduh95 aduh95 mentioned this pull request Oct 5, 2024
Merged
joyeecheung
joyeecheung approved these changes Oct 5, 2024
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though the unredability of the regexp seems to be getting out of hand..would be easier to read if it's just a bunch of "if index of A is smaller than index of B" checks

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 6, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 6, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62953/

@lpinca lpinca mentioned this pull request Oct 7, 2024
Closed
@targos targos linked an issue Oct 7, 2024 that may be closed by this pull request
Flaky test-loaders-workers-spawned #55301
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62986/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2024
@nodejs-github-bot nodejs-github-bot merged commit a05cb0d into nodejs:main Oct 8, 2024
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a05cb0d

@aduh95 aduh95 deleted the test-loaders-workers-spawned branch October 8, 2024 10:45
aduh95 added a commit that referenced this pull request Oct 9, 2024
@aduh95
test: make test-loaders-workers-spawned less flaky
17d2f9d 
PR-URL: #55172
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@aduh95 @louwers
test: make test-loaders-workers-spawned less flaky
5d23afe 
PR-URL: nodejs#55172
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Nov 16, 2024
@aduh95 @marco-ippolito
test: make test-loaders-workers-spawned less flaky
8e53245 
PR-URL: #55172
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Nov 16, 2024
Open
marco-ippolito pushed a commit that referenced this pull request Nov 17, 2024
@aduh95 @marco-ippolito
test: make test-loaders-workers-spawned less flaky
6027084 
PR-URL: #55172
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test-loaders-workers-spawned
3 participants
@aduh95 @nodejs-github-bot @joyeecheung