Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,test: drop SlowBuffer #55176

Closed
wants to merge 1 commit into from
Closed

src,test: drop SlowBuffer #55176

wants to merge 1 commit into from

Conversation

RafaelGSS
Copy link
Member

Depends on #55175.

It should land only on Node.js 24*.

To avoid inconsistencies, I'm adding a blocked label so we land on main only when 23 goes out.

@RafaelGSS RafaelGSS added blocked PRs that are blocked by other issues or PRs. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v23.x PRs that should not land on the v23.x-staging branch and should not be released in v23.x. labels Sep 30, 2024
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 30, 2024
@RedYetiDev
Copy link
Member

RedYetiDev commented Oct 1, 2024 •
edited
Loading

The removal of a feature must be semver major. Additionally, with this being semver major, it doesn't need all the "don't-land" labels, as it can't land on LTS lines anyway, right?

@RedYetiDev RedYetiDev added semver-major PRs that contain breaking changes and should be released in the next major version. and removed dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Oct 1, 2024
mcollina
mcollina approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RafaelGSS
Copy link
Member Author

The removal of a feature must be semver major. Additionally, with this being semver major, it doesn't need all the "don't-land" labels, as it can't land on LTS lines anyway, right?

Incorrect. It will be next-semver-major, it should not land on v23.x.

@RedYetiDev RedYetiDev removed blocked PRs that are blocked by other issues or PRs. dont-land-on-v23.x PRs that should not land on the v23.x-staging branch and should not be released in v23.x. labels Oct 16, 2024
@RedYetiDev
Copy link
Member

The blocking PR has landed, and this PR can no longer land on v23 due to the semver-major label. I've updated the labels accordingly.

@RafaelGSS
Copy link
Member Author

I'm open a fresh PR once v24 goes out :)

@RafaelGSS RafaelGSS closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RafaelGSS @nodejs-github-bot @RedYetiDev @mcollina @anonrig