meta: remove non-collaborators from mailmap #55183
Closed
+0
−428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
|
Do you know if those folks are OK with this change? |
|
I do not, but the mailmap AFAICT serves one purpose in this repository, and that's to check collaborator inactivities when updating the readme lists. These users really don't need to be in the mailmap as they arent in those lists. |
|
That's not correct, mailmap is defined by git (see https://git-scm.com/docs/gitmailmap), it's a tool that lets folks change which name and email address refer to them without modifying the commits they authored. Unless you got instructions from those folks to change their personal info, I'm -1. |
|
Good to know. Sorry for opening this PR, I'll focus my attention with the question "Who benefits from this?" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the
AUTHORSfile has been removed, non-collaborators/emeritus are no longer needed in the mailmap file.