-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_runner: update test context.assert #55186
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
test_runner
Issues and PRs related to the test runner subsystem.
labels
Sep 30, 2024
@jakecastelli FYI |
pmarchini
force-pushed
the
fix/test-context-doc
branch
from
September 30, 2024 18:09
ddfc86e
to
19ee6e0
Compare
MoLow
approved these changes
Sep 30, 2024
jakecastelli
approved these changes
Oct 1, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
aymen94
approved these changes
Oct 2, 2024
cjihrig
added
commit-queue
Add this label to land a pull request using GitHub Actions.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Oct 3, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 3, 2024
Landed in c9cffb7 |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #55186 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #55186 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Merged
aduh95
added
the
dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
label
Oct 9, 2024
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55186 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Nov 16, 2024
PR-URL: #55186 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Nov 17, 2024
PR-URL: #55186 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
test_runner
Issues and PRs related to the test runner subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates test runner
test context.assert
documentation.