test: update console wpt
#55192
Merged
test: update console wpt
#55192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
RedYetiDev
force-pushed
the
wpt-update-console
branch
from
8ed10eb
to
0f507ae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55192 +/- ##
=======================================
Coverage 88.41% 88.41%
=======================================
Files 652 652
Lines 186792 186792
Branches 36052 36057 +5
=======================================
+ Hits 165146 165151 +5
+ Misses 14898 14895 -3
+ Partials 6748 6746 -2 |
lpinca
approved these changes
Oct 1, 2024
github-actions
bot
removed
the
request-ci
RedYetiDev
added
the
author ready
mcollina
added
commit-queue
|
@RedYetiDev there seems to be conflicts now |
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55192 ✔ Done loading data for nodejs/node/pull/55192 ----------------------------------- PR info ------------------------------------ Title test: update `console` wpt (#55192) Author Aviv Keller <redyetidev@gmail.com> (@RedYetiDev) Branch RedYetiDev:wpt-update-console -> nodejs:main Labels test, author ready Commits 1 - test: update `console` wpt Committers 1 - RedYetiDev <38299977+RedYetiDev@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/55192 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55192 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 30 Sep 2024 19:34:34 GMT ✔ Approvals: 2 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/55192#pullrequestreview-2341366586 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/55192#pullrequestreview-2363790026 ⚠ This PR has conflicts that must be resolved ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-10-11T19:23:18Z: https://ci.nodejs.org/job/node-test-pull-request/63055/ - Querying data for job/node-test-pull-request/63055/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11303034636 |
I'll rebase this, and the other PRs about the WPT later today or tomorrow. Sorry for the delay! |
jasnell
approved these changes
Oct 12, 2024
BridgeAR
approved these changes
Oct 12, 2024
RedYetiDev
force-pushed
the
wpt-update-console
branch
from
0f507ae
to
0676a6d
Compare
RedYetiDev
added
web-standards
|
@mcollina conflicts resolved, can this land? ~ does it need a newer CI? |
Ethan-Arrowood
approved these changes
Oct 17, 2024
github-actions
bot
removed
the
request-ci
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in d7a0b56 |
aduh95
pushed a commit
that referenced
this pull request
Oct 19, 2024
PR-URL: #55192 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55192 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git node wpt consoleAll tests pass.