tools: update clang-format to v18

[RedYetiDev]

The previous attempt to update clang-format used a WASM compiled library, which unfortunately had it's issues, and was reverted.

This attempt uses the direct binaries instead of the WASM compiled library, so it can be ensured that they are identical to what is expected.

The source code for the updated clang-format library is https://github.com/RedYetiDev/node-core-clang-format. The binaries are from https://github.com/muttleyxd/clang-tools-static-binaries.

[RedYetiDev]

The issue with the WASM was that it wasn't writing the files correctly. I've confirmed that is not this case with this setup.

CC @nodejs/cpp-reviewers

[anonrig]

There is no way to validate the correctness, capability and security of a binary. If we are going to do this, it should be maintained by the Node.js organization, or it should be a package thats well known to the ecosystem.

[targos]

FWIW I still have an experimental repo that builds clang-format on GitHub actions in my computer (I deleted it from GitHub when the wasm-based tool landed), if you want to start from something.

[RedYetiDev]

FWIW I still have an experimental repo that builds clang-format on GitHub actions in my computer (I deleted it from GitHub when the wasm-based tool landed), if you want to start from something.

Interesting. I was using @muttleyxd's built binaries, but I'd be happy to take a look at your builds.

[targos]

https://github.com/targos/clang-format
With test build: https://github.com/targos/clang-format/actions/runs/11124135962

[RedYetiDev]

Thanks! I'll incorporate that workflow